Re: [collections] Bloom filters

2020-03-14 Thread Alex Herbert
> On 14 Mar 2020, at 17:02, Claude Warren wrote: > > I am confused. > > If we restrict what Shape stores to "m" and "t" we can provide methods to > estimate "n" and "p" for the estimated "n" > > If the constructors for Shape remains as as they are then developers don't > need to go online to

Re: [collections] Bloom filters

2020-03-14 Thread Claude Warren
I am confused. If we restrict what Shape stores to "m" and "t" we can provide methods to estimate "n" and "p" for the estimated "n" If the constructors for Shape remains as as they are then developers don't need to go online to get numbers to plug into Shape. They only need to go online if they

Re: [collections] Bloom filters

2020-03-14 Thread Alex Herbert
Should we not provide an API to compute this in code. Otherwise every developer who uses the code will have to go to the online Bloom filter calculator to check. They cannot do this dynamically in a program. If the equations are standard then I think we should provide a calculator. And Shape does

MalformedStreamException after Tomcat Upgrade.

2020-03-14 Thread Srijith Kochunni
Hi All, This is to seek help on a strange issue that we are observing. We recently did a minor upgrade of Tomcat from 9.0.30 to 9.0.31, in our application, in order to address vulnerability in AJP connector. Ever since then we have started seeing upload failures with our upload servle

Re: [collections] Bloom filters

2020-03-14 Thread Claude Warren
Shape is not intended to "Perform the standard computations using some of n, m, k, p to produce optimal values for the other values of n, m, k, p:" that is left to the developer to determine possibly with the help of https://hur.st/bloomfilter/ as referenced in the class javadoc. However, writing t

Re: [collections] Bloom filters

2020-03-14 Thread Alex Herbert
> On 10 Mar 2020, at 01:36, Alex Herbert wrote: > > I was going to modify the BloomFilter interface as discussed on this thread. > > However before that I have made some changes to the current code to tidy it > up. PR is [1]. The changes target the following: > > [1] https://github.com/apac