[VOTE][RESULT] Release Apache Commons BCEL 6.5.0 based on RC1

This vote passes with the following +1s: - Mark Roberts (non-binding) - Bruno P. Kinoshita (binding) - Amey Jadiye (non-binding) - Rob Tompkins (binding) - Gary Gregory (binding) Xeno Amess cast a non-binding +0. Gary On Mon, Jun 8, 2020 at 6:44 PM Gary Gregory wrote: > My +1 > > Gary > > On

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

My +1 Gary On Fri, Jun 5, 2020 at 6:02 PM Gary Gregory wrote: > We have fixed a few bugs and added some enhancements since Apache Commons > BCEL 6.4.1 was released, so I would like to release Apache Commons BCEL > 6.5.0. > > Apache Commons BCEL 6.5.0 RC1 is available for review here: >

Re: [Graph] moving to git

On Mon, Jun 8, 2020 at 2:50 AM Gilles Sadowski wrote: > Hello. > > Repository available: > https://gitbox.apache.org/repos/asf?p=commons-graph.git > > Thanks Gilles. Regards, > Gilles > > - > To unsubscribe, e-mail:

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Here is how you can build on Java 11: mvn site -Dcommons.spotbugs.version=4.0.0 Gary On Mon, Jun 8, 2020 at 11:00 AM Rob Tompkins wrote: > Yep spotbugs did it. > > And agree with the bafflement of maven plugins (even one’s I’ve written > baffle me :-p ) > > -Rob > > > On Jun 8, 2020, at

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

> On Jun 8, 2020, at 10:58 AM, Gary Gregory wrote: > > On Mon, Jun 8, 2020 at 10:44 AM Rob Tompkins > wrote: > >> Gotcha…just ran for posterity “ mvn -Dclirr.skip=true -Djapicmp.skip=true >> clean test install site” and got the following (don’t have a good answer

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Yep spotbugs did it. And agree with the bafflement of maven plugins (even one’s I’ve written baffle me :-p ) -Rob > On Jun 8, 2020, at 10:55 AM, Gary Gregory wrote: > > On Mon, Jun 8, 2020 at 10:38 AM Gary Gregory > wrote: > >> Thanks for the review. >> >>

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

On Mon, Jun 8, 2020 at 10:44 AM Rob Tompkins wrote: > Gotcha…just ran for posterity “ mvn -Dclirr.skip=true -Djapicmp.skip=true > clean test install site” and got the following (don’t have a good answer > here, but as "mvn test” works I’m not concerned): > > [INFO] <<<

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

On Mon, Jun 8, 2020 at 10:38 AM Gary Gregory wrote: > Thanks for the review. > > Yeah, the code coverage has never been great for this component. > > Clirr should not even be run, you should use japicmp, to this effect the > POM sets: > > false > true > > When I run the build on Java 11

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Gotcha…just ran for posterity “ mvn -Dclirr.skip=true -Djapicmp.skip=true clean test install site” and got the following (don’t have a good answer here, but as "mvn test” works I’m not concerned): [INFO] <<< clirr-maven-plugin:2.8:clirr < compile @ bcel <<< [INFO] [INFO] 'compile' forked phase

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Thanks for the review. Yeah, the code coverage has never been great for this component. Clirr should not even be run, you should use japicmp, to this effect the POM sets: false true When I run the build on Java 11 with: "mvn clean install site -V": Apache Maven 3.6.3

Re: [VOTE] Release Apache Commons BCEL 6.5.0 based on RC1

Everything looks good to me. Only nits: couldn’t get mvn install or mvn site to work with java 11 (clirr failure), and code coverage is lower than I prefer (but that’s ok for a release). +1 Cheers, -Rob > On Jun 5, 2020, at 6:02 PM, Gary Gregory wrote: > > We have fixed a few bugs and