Re: [geometry] IO Modules

2021-01-27 Thread Gilles Sadowski
Hello. Le lun. 25 janv. 2021 à 13:40, Matt Juntunen a écrit : > > Hello, > > I have two main goals for the IO modules here: > > 1. Provide a simple, high-level API (i.e. IO3D) for reading and writing > geometry with a minimum of fuss. Sure. But this high-level API looks like "syntactic suga

Re: NPE in CSVFormat

2021-01-27 Thread Gary Gregory
CSV does not use LOGGING... Gary On Wed, Jan 27, 2021, 21:01 Gilles Sadowski wrote: > Le jeu. 28 janv. 2021 à 02:30, Gary Gregory a > écrit : > > > > You can't attach files to this mailing list. > > > > You'll have to figure out GitHub PRs so we can see what you're proposing > to > > do ;-) >

Re: NPE in CSVFormat

2021-01-27 Thread Gilles Sadowski
Le jeu. 28 janv. 2021 à 02:30, Gary Gregory a écrit : > > You can't attach files to this mailing list. > > You'll have to figure out GitHub PRs so we can see what you're proposing to > do ;-) Or use JIRA... But about the issue itself: Hasn't "Commons Logging" been superseded by the "Log4j" proje

Re: [math] FastMath isn't fast...

2021-01-27 Thread Gilles Sadowski
Hi. Le mer. 27 janv. 2021 à 17:39, Erik Svensson a écrit : > > Hello all! > > I work for a fintech company and we do a lot of risk computations using, > among other things, FastMath. > Recently I had the opportunity to do some performance testing using JMH and > found, to my surprise, that once

Re: NPE in CSVFormat

2021-01-27 Thread Gary Gregory
You can't attach files to this mailing list. You'll have to figure out GitHub PRs so we can see what you're proposing to do ;-) Gary On Wed, Jan 27, 2021, 15:40 Derek Bennett wrote: > While writing integration tests for my software, I noticed that many calls > to commons logging were terminati

NPE in CSVFormat

2021-01-27 Thread Derek Bennett
While writing integration tests for my software, I noticed that many calls to commons logging were terminating with NullPointerException. I checked out the code and added input validation to CSVFormat.printRecord. While adding my unit test, I found that I broke another unit test. It appears that so

Re: [math] FastMath isn't fast...

2021-01-27 Thread Matt Sicker
Are we even allowed to use the intrinsic annotation in user code? Java 9 introduces modules in that they wish to hide internal details, and this sounds like an internal detail? On Wed, 27 Jan 2021 at 10:39, Erik Svensson wrote: > > Hello all! > > I work for a fintech company and we do a lot of ri

[IO][IO-707] Add optional postcondition checks with assert #192

2021-01-27 Thread Gary Gregory
Hi All, We do not use asserts in the main code bases. The PR "[IO-707] Add optional postcondition checks with assert #192" proposes to add some. Thoughts? Gary

[math] FastMath isn't fast...

2021-01-27 Thread Erik Svensson
Hello all! I work for a fintech company and we do a lot of risk computations using, among other things, FastMath. Recently I had the opportunity to do some performance testing using JMH and found, to my surprise, that once you move beyond Java 8, java.lang.Math outperforms FastMath, sometimes qu