Re: [MATH][GA] Build Failure for PR #204

2022-02-02 Thread Avijit Basak
Hi All Please see my comments below. >Strange that the "pom.xml" in PR #204 still refers to version 1.0 of >Commons Numbers, instead of version 1.1-SNAPSHOT. >This creates many "NoClassDefFound" errors that were fixed with >commit 7e2213f2e5a536ad49d549d21f9eed9e71db5638 in branch >"featu

Re: [All] GSoC 2022

2022-02-02 Thread Alex Herbert
On Mon, 31 Jan 2022 at 15:06, Gilles Sadowski wrote: > > Hello. > > Le jeu. 27 janv. 2022 à 18:09, Alex Herbert a > écrit : > > > > I would be willing to go through GSOC again. > > Thanks; I know that back in 2020, it had been a disproportionate > amount of work... > > > I think that the > > sta

Re: [VOTE][CANCELLED] Release Apache Commons Daemon 1.2.5 based on RC1

2022-02-02 Thread Gary Gregory
1.3.0, not 1.30 ;-) Gary On Wed, Feb 2, 2022, 02:29 Mark Thomas wrote: > This vote has been cancelled as the consensus is that the next version > needs to be 1.30 rather than 1.2.5. > > Mark > > > On 27/01/2022 22:29, Mark Thomas wrote: > > We have fixed a few bugs and added some enhancements s

Re: [MATH][GA] Build Failure for PR #204

2022-02-02 Thread Gilles Sadowski
Hi. Le mer. 2 févr. 2022 à 09:29, Avijit Basak a écrit : > > Hi All > > Please see my comments below. > > [...] > > > And there was this old issue that the "" should contain > the name of the top-level package, i.e. "math4", not "math". > -- There was a review comment for PR#197 to remove

Re: [All] GSoC 2022

2022-02-02 Thread Gilles Sadowski
Hello. Le mer. 2 févr. 2022 à 10:47, Alex Herbert a écrit : > > On Mon, 31 Jan 2022 at 15:06, Gilles Sadowski wrote: > > > > Hello. > > > > Le jeu. 27 janv. 2022 à 18:09, Alex Herbert a > > écrit : > > > > > > I would be willing to go through GSOC again. > > > > Thanks; I know that back in 202

Optimizing ConstantPoolGen

2022-02-02 Thread Stefan Reich
Hi folks, I'm getting into compiling my own little scripting language into Java byte code. Short experimentation with both Javassist and BCEL led me to use BCEL. Just a quick question: Has anyone looked into optimizing constant lookups in ConstantPoolGen (e.g. addInteger)? Right now, they are jus

Re: Optimizing ConstantPoolGen

2022-02-02 Thread Gary Gregory
I would guess not. PRs (with tests) are welcome in GitHub. Gary On Wed, Feb 2, 2022, 12:02 Stefan Reich wrote: > Hi folks, > > I'm getting into compiling my own little scripting language into Java byte > code. Short experimentation with both Javassist and BCEL led me to use > BCEL. > > Just a q

Re: Optimizing ConstantPoolGen

2022-02-02 Thread Stefan Reich
Thank you On Wed, 2 Feb 2022 at 20:24, Gary Gregory wrote: > I would guess not. PRs (with tests) are welcome in GitHub. > > Gary > > On Wed, Feb 2, 2022, 12:02 Stefan Reich > wrote: > > > Hi folks, > > > > I'm getting into compiling my own little scripting language into Java > byte > > code. Sh

Re: BCEL: Can't load Object.class using LDC

2022-02-02 Thread Gary Gregory
You should try the latest from git master. Gary On Wed, Feb 2, 2022, 15:41 Stefan Reich wrote: > Hi again, > > actual problem this time... > > I think I am doing everything right... Decompilation in javap -v looks > just like it should. But I get a VerifyError... I'm using JDK 17. Full > progra

Re: BCEL: Can't load Object.class using LDC

2022-02-02 Thread Stefan Reich
Hmm, no change with latest version. I did "git clone https://github.com/apache/commons-bcel.git"; and "mvn package". stefan@lenovo-ThinkPad-X220:~/dev/classreftest$ javac -cp bcel-6.6.0-SNAPSHOT.jar MakeBadClassFile.java stefan@lenovo-ThinkPad-X220:~/dev/classreftest$ java -cp bcel-6.6.0-SNAPSHOT

Re: BCEL: Can't load Object.class using LDC

2022-02-02 Thread Stefan Reich
I'm mainly curious how it's possible that everything looks completely normal in javap (checked a dozen times), but the class verifier complains anyway? Something has to be different. Is there a way to dig deeper into a class file? Greetings On Wed, 2 Feb 2022 at 23:14, Stefan Reich < stefan.reich

Re: BCEL: Can't load Object.class using LDC

2022-02-02 Thread Romain Manni-Bucau
Hi, Maybe a bit ot of topic but did you check with asm (using classreader for ex) if it is readable for it? Javap in verbose mode is hard to read humanly (and not verbosel does not mean much) so an issue can still be hidden. Romain Manni-Bucau @rmannibucau | Blo