Re: [collections] BloomFilterExtractor.flatten()

2024-10-04 Thread Alex Herbert
You cannot return an empty BloomFilter when there is no array of BloomFilters to flatten. The BloomFilter is tied to a Shape. Without a shape you cannot know what size filter to create. So we have to return null or throw an exception. Whatever choice must be documented. Note we do not currently ch

Re: [collection] AbstractLinkedListForJava21 ?

2024-09-11 Thread Alex Herbert
It was copied from the same package. The current AbstractLinkedList is source incompatible with JDK 21 due to new default methods added to the List interface. So Collections does not compile on JDK 21. Anyone using the AbstractLinkedList and compiling on JDK 21 must switch their source to use Abstr

[ANNOUNCE] Apache Commons Statistics Version 1.1 Released

2024-08-20 Thread Alex Herbert
S-71: Add commons-statistics-descriptive module for implementations of univariate statistics. Contains base interfaces for statistics and implementations for individual statistics (e.g. Min, Max, Sum, Mean, Variance) and combinations of statistics.

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-20 Thread Alex Herbert
This vote passes with the following result: +1: Bruno Kinoshita (binding) +1: Gary Gregory (binding) +1: Alex Herbert (binding) Thanks to everyone who reviewed the candidate. I will proceed with the release. Alex On Tue, 20 Aug 2024 at 10:12, Alex Herbert wrote: > > My +1 > > On

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-20 Thread Alex Herbert
My +1 On Mon, 19 Aug 2024 at 12:59, Gary Gregory wrote: > > On Mon, Aug 19, 2024 at 7:21 AM Alex Herbert > wrote: > > > On Sat, 17 Aug 2024 at 17:24, Gary Gregory wrote: > > > > > > Thank you for the details Alex. > > > > > > WRT SBOM gen

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-19 Thread Alex Herbert
On Sat, 17 Aug 2024 at 17:24, Gary Gregory wrote: > > Thank you for the details Alex. > > WRT SBOM generation, I think this will be become more important as > time goes on, so anything we can do to improve the ecosystem will benefit > us all IMO. FYI: I traced the warning output in the SPDX plugi

Re: [VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-17 Thread Alex Herbert
Thanks Gary, see notes below... On Sat, 17 Aug 2024 at 15:12, Gary Gregory wrote: > > +1 > > - I tested the src zip files. > - ASC OK > - SHA512 OK > - default Maven build OK > - Odd output: > > [WARNING] > /Users/garydgregory/rc/stats/commons-statistics-1.1-src/commons-statistics-descriptive/sr

[VOTE] Release Apache Commons Statistics 1.1 based on RC1

2024-08-16 Thread Alex Herbert
[ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) The following is intended as a helper and refresher for reviewers. Validating a release candidate ==

[release] No description on staged Nexus repo

2024-08-16 Thread Alex Herbert
To release managers, During the staging of Statistics 1.1 RC1 I made an error and did not add a description when closing Nexus repo 1773. The repository contents are OK. Please do not drop this repo during housekeeping. Alex - T

[ANNOUNCE] Apache Commons Numbers Version 1.2 Released

2024-08-12 Thread Alex Herbert
uot;ArithmeticUtils": Improve performance of GCD for longs. Thanks to Matthias Langer. o "ArithmeticUtils": Improve performance of remainderUnsigned and divideUnsigned. Thanks to Sebb, Alex Herbert. o NUMBERS-199: "Precision": Document inaccurate decimal valu

Re: [VOTE][RESULT] Release Apache Commons Numbers 1.2 based on RC1

2024-08-12 Thread Alex Herbert
This vote passes with the following result: +1: Bruno Kinoshita (binding) +1: Gary Gregory (binding) +1: Tomas Lanik +1: Gilles Sadowski (binding) +1: Alex Herbert (binding) Thanks to everyone who voted. Alex On Mon, 12 Aug 2024 at 10:27, Alex Herbert wrote: > > My +1. > > Ale

Re: [VOTE] Release Apache Commons Numbers 1.2 based on RC1

2024-08-12 Thread Alex Herbert
My +1. Alex On Sat, 10 Aug 2024 at 01:25, Gilles Sadowski wrote: > > Hi. > > $ git clone https://gitbox.apache.org/repos/asf/commons-numbers.git > --branch commons-numbers-1.2-RC1 commons-numbers-1.2-RC1 > $ cd commons-numbers-1.2-RC1 > $ git tag -v commons-numbers-1.2-RC1 > -> OK > > $ mvn clea

Re: [VOTE] Release Apache Commons Numbers 1.2 based on RC1

2024-08-08 Thread Alex Herbert
e/checkstyle.html > . > Not a big issue. > > Inspected signatures and contents of two files from dist area, and found no > issues. > > Thanks! > > On Thu, 8 Aug 2024 at 17:03, Alex Herbert wrote: > > > We have fixed a few bugs and added enhancements since Apache

[VOTE] Release Apache Commons Numbers 1.2 based on RC1

2024-08-08 Thread Alex Herbert
he.org/commons/KEYS Please review the release candidate and vote. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manag

Re: [numbers][release] Nexus staging error for numbers 1.2 RC1

2024-08-08 Thread Alex Herbert
A reroll has fixed the nexus staging issue. On Thu, 8 Aug 2024 at 15:24, Alex Herbert wrote: > > I have just staged a release candidate for Commons Numbers 1.2 RC1. > However nexus has created two repository IDs: > 1765: contains all the expected module jars and signatures > 176

[numbers][release] Nexus staging error for numbers 1.2 RC1

2024-08-08 Thread Alex Herbert
I have just staged a release candidate for Commons Numbers 1.2 RC1. However nexus has created two repository IDs: 1765: contains all the expected module jars and signatures 1766: contains the only the parent pom In a strange twist all the metadata for the parent pom is in 1765, e.g. commons-number

[ANNOUNCE] Apache Commons RNG 1.6 released

2024-07-16 Thread Alex Herbert
The Apache Commons Team is pleased to announce the availability of version 1.6 of "Apache Commons RNG". Apache Commons RNG provides Java implementations of pseudo-random numbers generators. Changes in this version include: New features: o RNG-186: Correct the module OSGi exports. Use of multipl

Re: [VOTE] Release Apache Commons Codec 1.17.1 based on RC1

2024-07-15 Thread Alex Herbert
Built from the source archive commons-codec-1.17.1-src.tar.gz using: Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) Maven home: /Users/ah403/software/apache-maven-3 Java version: 21.0.3, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-21.jdk/Contents/Hom

Re: [VOTE][RESULT] Release Apache Commons RNG 1.6 based on RC2

2024-07-15 Thread Alex Herbert
This vote passes with the following votes: +1: Gilles Sadowski (binding) +1: Gary Gregory (binding) +1: Alex Herbert (binding) Thanks to all who inspected RC1 and 2. Alex On Fri, 12 Jul 2024 at 14:51, Gary D. Gregory wrote: > +1 > > I tested the src zip file: > - SHA512 O

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-15 Thread Alex Herbert
RC1 is cancelled for RC2 On Tue, 9 Jul 2024 at 12:12, Gary Gregory wrote: > Thanks Alex! > > Gary > > On Mon, Jul 8, 2024, 4:22 PM Alex Herbert > wrote: > > > Hi Gary, > > > > Thanks for the feedback. I'll fix the docs module tomorrow. It is only &

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-12 Thread Alex Herbert
My +1 Another review would be appreciated. On Thu, 11 Jul 2024 at 21:13, Alex Herbert wrote: > RC2 is still ok. Only nits with the site generation so far. > > On Thu, 11 Jul 2024, 19:31 Gary Gregory, wrote: > >> Is RC2 still alive or are there changes coming due to this di

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-11 Thread Alex Herbert
> > > On Jul 11, 2024, at 1:57 PM, Alex Herbert > > wrote: > > > > > > Hi Gilles, > > > > > > Thanks for the feedback. It seems that revapi is not a robust plugin, > but > > > japicmp also has issues without the packaged ja

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-11 Thread Alex Herbert
t; > Le mar. 9 juil. 2024 à 14:22, Alex Herbert a écrit : > > > > We have fixed a few bugs and added enhancements since Apache Commons RNG > > 1.5 was released, so I would like to release Apache Commons RNG 1.6. > > > > Apache Commons RNG 1.6 RC2 is available for

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-11 Thread Alex Herbert
Hi Gilles, On Thu, 11 Jul 2024 at 13:30, Gilles Sadowski wrote: > > [In the cloned directory.] > Default maven goal succeeds. > > > > > mvn site > > The above goal fails: > ---CUT--- > [INFO] > > [INFO] Reactor Summary for

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-09 Thread Alex Herbert
compatibility checks as a previous release change was flagged as binary incompatible by JApiCmp but was not by revapi. This required some exclusions for JApiCmp. The build still retains configuration for both plugins. Alex On Tue, 9 Jul 2024 at 13:21, Alex Herbert wrote: > We have fixed a few bugs

[VOTE] Release Apache Commons RNG 1.6 based on RC2

2024-07-09 Thread Alex Herbert
OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) The following is intended as a helper and refresher for reviewers. Validating a release candidate ===

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-08 Thread Alex Herbert
tUniformNextLongInRange:156->checkNextLongInRange:404->checkNextInRange:528 > org.apache.commons.rng.core.source32.PcgXshRr32: Too many failures for n = > 32, sample size = 1000 (12 out of 500 tests failed, chi2 > 21.666=[24.699, > 23.464, 25.043, 31.397, 31.739, 22.288, 24.637, 2

Re: [VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-08 Thread Alex Herbert
t; Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256) > > Maven home: C:\java\apache-maven-3.9.8 > > Java version: 17.0.11, vendor: Eclipse Adoptium, runtime: C:\Program > Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot > > Default locale: en_US, platform encoding: Cp1252 &g

[VOTE] Release Apache Commons RNG 1.6 based on RC1

2024-07-05 Thread Alex Herbert
. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thank you, Alex Herbert, Release Manager (using key BC87A3FD0A54480F0BADBEBD21939FF0CA2A6567) The foll

Re: [parent] Possibe change to moditect configuration for internal packages

2024-07-04 Thread Alex Herbert
> On Thu, Jul 4, 2024, 9:18 AM Alex Herbert > wrote: > > > The RNG component has an internal package. So to not export this in the > > module info I had to tweak the exports for moditect inherited from > commons > > parent with a profile

[parent] Possibe change to moditect configuration for internal packages

2024-07-04 Thread Alex Herbert
The RNG component has an internal package. So to not export this in the module info I had to tweak the exports for moditect inherited from commons parent with a profile: java-9-up [9,) org.moditect moditect-maven-p

[rng][numbers][statistics] Release latest dev versions

2024-07-04 Thread Alex Herbert
I would like to release the statistics component as it has some useful new modules. This requires: rng-1.6 numbers-1.2 statistics-1.1 I believe RNG is ready to go out now. It only has one new class and a fix for the Java 9 module exports. I do not think the other components have any outstanding i

Re: TEST fails for commons-compress:1.26

2024-06-26 Thread Alex Herbert
Hi, There have been some patch releases since 1.26. Can you try with the latest release (1.26.2): https://commons.apache.org/compress/download_compress.cgi If this still doesn't work can you provide the output of 'mvn -v' when run from within the source root directory. This will provide your bui

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Alex Herbert
On Wed, 12 Jun 2024 at 18:03, Department 8 wrote: > Sorry Alex just now saw your email, before sending out the PR! > > I had done just for isAllEmpty and isAllBlank. > > Can you tell me more on what can be done, when you said the following: > > If you are simply negating the result of another met

Re: [LANG] Add Any Checks for Not Checks in StringUtils

2024-06-12 Thread Alex Herbert
Hi, On Wed, 12 Jun 2024 at 17:23, Department 8 wrote: > Hey! > > Recently when using StringUtils in one of our projects I had felt the > urgent need to have a utility method like => isAnyNotBlank. > > I was able to achieve this using the negation of isAllBlank, so I am > thinking of introducing

Re: [COLLECTIONS/Bloomfilter] A question of streams

2024-06-11 Thread Alex Herbert
You need to test it with some realistic data for a benchmark. In Commons Statistics we have a case where all elements of an array are passed to a consumer. So you have either: int[] a = ... IntConsumer c = ... Arrays.stream(a).forEach(c::accept) vs for (final int i : a) { c.accept(i); } W

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
Tracking this with: https://issues.apache.org/jira/browse/COLLECTIONS-855 On Sat, 18 May 2024 at 08:26, Alex Herbert wrote: > Thanks for highlighting this. I did not use the original paper and based > the implementation on Wikipedia. > > I think the issue is that we use i in [0

Re: [Collections] Implementation of EnhancedDoubleHasher

2024-05-18 Thread Alex Herbert
Thanks for highlighting this. I did not use the original paper and based the implementation on Wikipedia. I think the issue is that we use i in [0, k); we can correct this by using i in [1, k]. The order inside the loop would not change but we would have to decrement i to use in the assignment giv

Re: [COLLECTIONS] Is the changes.xml file automatically updated by pull merge?

2024-05-12 Thread Alex Herbert
No. Just add it as a second commit after merge. On Sun, 12 May 2024, 11:12 Claude Warren, wrote: > -- > LinkedIn: http://www.linkedin.com/in/claudewarren >

Re: [Collections] Suppliers, Iterables, and Producers

2024-04-30 Thread Alex Herbert
On Tue, 30 Apr 2024 at 14:45, Gary D. Gregory wrote: > Hi Claude, > > Thank you for the detailed reply :-) A few comments below. > > On 2024/04/30 06:29:38 Claude Warren wrote: > > I will see if I can clarify the javadocs and make things clearer. > > > > What I think I specifically heard is: > >

Re: [Collections] Suppliers, Iterables, and Producers

2024-04-28 Thread Alex Herbert
Hi Gary, I am in favour of using nomenclature and patterns that will be familiar to a Java developer. But only if they match the familiar JDK use patterns. The Bloom filter package has some atypical use patterns that have driven the current API to where it is. I'll try and describe these below. O

Re: [Collections] Bloom filter package's Hasher to extend Function

2024-04-25 Thread Alex Herbert
On Thu, 25 Apr 2024 at 21:47, Gary D. Gregory wrote: > Hi Clause, Albert, and all, > > Why not make Hasher more functional like so: > > public interface Hasher extends Function > > It would implement the standard `apply` instead of `indices`. > > WDYT? > > Gary > I do not see any problems with t

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-20 Thread Alex Herbert
IndexProducer indexProducer, Consumer result) Why else do you require indices of layers? If there is no use case other than layer retrieval then this seems to be the wrong API. Alex > Claude > > On Fri, Apr 19, 2024 at 11:06 AM Alex Herbert > wrote: > > > On Fri, 19 Apr 2024 at

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-19 Thread Alex Herbert
t.next(); if (i == 3) { it.remove(); } } System.out.println(d); prints: [1, 2, 4, 5] So it is easy to iterate the layers and remove them in Order(1) time (per removal). Alex > > On Wed, Apr 17, 2024 at 2:17 PM Alex Herbert > wrote: > > > Looks good t

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-17 Thread Alex Herbert
(so 2 new methods, one exposed). > > > > The next() method is used when external circumstances dictate that a new > > layer should be created. I think a StableBloomFilter I implemented > > required it, but I do not have the code to hand at the moment. > > > > Clau

Re: [Collections-BloomFilter][Discuss] missing functionality?

2024-04-09 Thread Alex Herbert
Hi Claude, Q. What is your current clean-up filter, i.e. the Consumer>? I assume you are using a custom one. The current collections code only has 2 functional implementations. One will remove the newest filter if it is empty, one will remove the oldest filters until the size is below a limit. Si

Re: [Collections] New release candidate for 4.5.0-beta1 or -M1 and new Bloom Filter package

2024-03-25 Thread Alex Herbert
On Mon, 25 Mar 2024 at 13:12, Gary Gregory wrote: > Hi All, > > 4.5.0 will contain a new package for Bloom Filters. > > Since this is a new package and is non-trivial, I propose we release a > version called 4.5.0-M1 or 4.5.0-beta1 to let users try this out while > giving us the change to make br

Re: [Net] JUnit 5 migration discussion

2024-02-29 Thread Alex Herbert
Use of abstract classes does work in JUnit 5. I've written a lot of JUnit 5 tests that use abstract test classes which define the @ParameterizedTest/@Test fixtures and then concrete child classes that are run by the framework. It is supported but IIRC it is not recommended in the JUnit 5 documentat

Re: New to community-Introducing myself

2023-12-31 Thread Alex Herbert
On Sun, 31 Dec 2023 at 20:54, Narasimha asuri wrote: > > Hi, > > Chary here, I am a beginner java developer and I used many components > of Apache commons library in my previous project, Lang, IO, Math. Saw the > commons - math library and am on looking to help solve some issues. > > > > Chary

Re: (commons-numbers) branch master updated: Simplify conversion of numbers to unsigned

2023-12-24 Thread Alex Herbert
he.org/repos/asf/commons-numbers.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new a15b3e68 Simplify conversion of numbers to unsigned > > a15b3e68 is described below > > > > commit a15b3e68136dd94ea20e4085afc45aa73d4

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 16:31, sebb wrote: > > On Sun, 24 Dec 2023 at 16:14, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > > > > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert > > > wrote: > > > > &g

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 13:58, sebb wrote: > > On Sun, 24 Dec 2023 at 13:16, Alex Herbert wrote: > > > > On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold > > wrote: > > > > > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > >

Re: (commons-numbers) 01/01: Use Java 1.8 methods to simplify the ArithmeticUtils methods remainderUnsigned and divideUnsigned (both int and long)

2023-12-24 Thread Alex Herbert
I would be wary of this simplification without a performance test. In the Numbers class the int methods do not use long arithmetic. The long methods do not use BigInteger. This is unlike those methods in my JDK 8 source code which do and are likely much slower. A quick check in JDK 21 finds this i

Re: (commons-numbers) branch java8-simplify created (now 2f60d424)

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 13:20, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > sebb pushed a change to branch java8-simplify > in repository https://gitbox.apache.org/repos/asf/commons-numbers.git > > > at 2f60d424 Use Java 1.8 methods to simplify the Arithm

Re: [MATH][NUMBERS] Method to convert unsigned long to BigInteger

2023-12-24 Thread Alex Herbert
On Sun, 24 Dec 2023 at 11:45, Elliotte Rusty Harold wrote: > > On Sun, Dec 24, 2023 at 9:59 AM sebb wrote: > > > > Both Numbers and Statistics have implementations of > > > > BigInteger toUnsignedBigInteger(long treatedAsUnsigned) > > > > Can you describe a use case for this? That might help deci

Re: [ALL] Deploying SNAPSHOTS from GH workflows

2023-12-20 Thread Alex Herbert
On Wed, 20 Dec 2023 at 17:15, sebb wrote: > > Numbers is now deploying OK, as does Crypto. I cannot see anything in the GH action config that specifies that deploy should be only on the master/main branch in the original Apache repo. How is the deploy goal handled in forked repos and subsequentl

Re: [NUMBERS] GH deploy snapshot test

2023-12-20 Thread Alex Herbert
On Wed, 20 Dec 2023 at 13:19, sebb wrote: > > On Tue, 19 Dec 2023 at 16:08, Alex Herbert wrote: > > > > Thanks Sebb, > > > > Note that previously the GH action was running the default goal: > > 'clean verify javadoc:javadoc'. > > > >

Re: [NUMBERS] GH deploy snapshot test

2023-12-19 Thread Alex Herbert
Thanks Sebb, Note that previously the GH action was running the default goal: 'clean verify javadoc:javadoc'. Since we now need to specify the 'deploy' goal as well the above defaults can be switched in for your additions when Infra have created the credentials. Alex On Tue, 19 Dec 2023 at 14:2

Re: [ALL] Deploying SNAPSHOTS from GH workflows

2023-12-19 Thread Alex Herbert
On Tue, 19 Dec 2023 at 10:41, sebb wrote: > > Crypto now has a workflow [4] that deploys a SNAPSHOT version. > > I don't know if we want to do this for all components, but if so, the > process is: > - raise INFRA Jira to request access to the secrets that hold the > credentials [1] > - use the jav

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
On Tue, 12 Dec 2023 at 13:20, Gary Gregory wrote: > > What's the best way to document this do you think? That lang is tested (and so should be built) with the latest JDK of the respective stable release (8, 11, 17, 21)? This could live on the README in the GH repo. This would require an update t

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
se line you are using, which is not the case here, and > might not matter. > > Note that some of the tests make allowances for bugs in the JDK date > classes. > > Gary > > On Tue, Dec 12, 2023, 6:18 AM Alex Herbert wrote: > > > I can con

Re: Apache Common Lang -- How do I compile or did I find a bug

2023-12-12 Thread Alex Herbert
I can confirm I see 3 test failures in the FastDateParser using: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Java version: 17.0.6, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home Default locale: en_GB, platform encoding: UTF-8 OS

Re: [LAZY] was: [VOTE] Release Apache Commons Parent 65 based on RC1

2023-11-18 Thread Alex Herbert
On Sat, 18 Nov 2023 at 12:49, Gary Gregory wrote: > > On Sat, Nov 18, 2023 at 3:36 AM Alex Herbert wrote: > > > > Installed from the maven tag. > > > > Built lang and statistics using JDK 8 and 11: > > > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b

Re: [LAZY] was: [VOTE] Release Apache Commons Parent 65 based on RC1

2023-11-18 Thread Alex Herbert
Installed from the maven tag. Built lang and statistics using JDK 8 and 11: Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /Users/ah403/mvn/mvn Java version: 1.8.0_362, vendor: Temurin, runtime: /Library/Java/JavaVirtualMachines/temurin-8.jdk/Contents/Home/jre Default l

Re: (commons-rng) branch master updated: Normalize spelling to US English

2023-10-31 Thread Alex Herbert
Note: On Tue, 31 Oct 2023 at 10:21, wrote: > Normalize spelling to US English > .../commons/rng/examples/stress/RNGUtils.java | 30 > ++ > +/** Message for an unrecognized source64 mode. */ > +private static final String UNRECOGNISED_SOURCE_64_MODE = "Unrec

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
method by other means. Alex On Fri, 20 Oct 2023 at 20:16, Gary D. Gregory wrote: > > Hi Alex, > > I'd prefer if you could give a shot at adjusting this test when you can take > the time. > > TY, > Gary > > On 2023/10/20 18:17:35 Alex Herbert wrote: > > O

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
On Fri, 20 Oct 2023 at 18:55, Alex Herbert wrote: > > The chi-square critical value (13.82) is correct: > > >>> from scipy.stats import chi2 > >>> chi2(2).isf(0.001) > 13.815510557964274 > > The test seems to fail with the expected frequency when run loca

Re: [lang] RandomStringUtilsTest.testRandomStringUtilsHomog fails a lot

2023-10-20 Thread Alex Herbert
The chi-square critical value (13.82) is correct: >>> from scipy.stats import chi2 >>> chi2(2).isf(0.001) 13.815510557964274 The test seems to fail with the expected frequency when run locally. I annotated with: @RepeatedTest(value = 10) I observe 93 failures (just under 1 in 1000). So it i

Re: [ALL] Java CI badge does not agree with workflow status

2023-10-20 Thread Alex Herbert
Navigating to the Java CI workflow you can generate a badge using the ... menu in the top right next to the search filter. This creates a badge with a different URL to that currently in use: Current: [![GitHub Actions Status](https://github.com/apache/commons-build-plugin/workflows/Java%20CI/badge

Re: [Text] Java 21 failure with a double

2023-10-20 Thread Alex Herbert
check against the digits output from Double.toString to ensure all digits are present. Alex [1] https://github.com/apache/commons-text/pull/467 On Mon, 16 Oct 2023 at 18:37, Alex Herbert wrote: > > TLDR; The Double.toString(double) value is different for > -9.354004711977437E17 on JDK 2

Re: [Text] Java 21 failure with a double

2023-10-16 Thread Alex Herbert
TLDR; The Double.toString(double) value is different for -9.354004711977437E17 on JDK 21 and earlier JDKs: JDK 21: -9.354004711977437E17 JDK 17: -9.3540047119774374E17 The DoubleFormat class is built upon Double.toString. So the test fails due to this change. --- More details: On JDK 21 Double

Re: [ALL] Standardise Maven defaultGoal in components?

2023-10-08 Thread Alex Herbert
On Sun, 8 Oct 2023 at 22:53, sebb wrote: > > > > On Oct 8, 2023, at 7:11 AM, sebb wrote: > > > > > > There are currently lots of variations of the defaultGoal in different > > > components. > > > > > > It may be sensible to establish a standard setting which components > > > should adopt (unless

Re: [VOTE][LAZY] Release Apache Commons Parent 63 based on RC2

2023-10-02 Thread Alex Herbert
Can you provide the usage for the new property? This is listed in the release notes as a new feature thanks to dependabot. But the commit was a single line added by Gary. I do not think it is attributed to dependabot. It is added under the release management section for properties for the Commons

Re: [BUILD-PLUGIN] Drop component list from README template?

2023-10-02 Thread Alex Herbert
On Mon, 2 Oct 2023 at 10:05, sebb wrote: > > The Build Plugin currently includes a list of components in the README > template. > > This duplicates information provided elsewhere, and gets out of date. > > Since this info is in every GH repo, any changes also need to be > applied to every one of

[statistics] descriptive module

2023-09-26 Thread Alex Herbert
I have been looking at continuing the work on the descriptive module to add the remaining stats found in Commons Math. Before adding more classes I would like to address the current implementation pattern. The statistics in the descriptive module are currently abstract classes with a concrete inne

Re: [MATH] Inconsistent artifactId for parent pom

2023-09-20 Thread Alex Herbert
On Wed, 20 Sept 2023 at 14:24, sebb wrote: > > The artifactId for the parent pom is > > commons-math-parent > > whereas all the child poms have the prefix > > commons-math4- > > Seems to me this ought to be fixed before the first GA release > (current is 4.0-beta2) The current parent was probably

Re: [DRAFT][REPORT] September 2023

2023-09-13 Thread Alex Herbert
You could add that we had a successful participant in Google Summer of Code 2023 working on the statistics sub-project. This may apply to the community section. Alex On Wed, 13 Sept 2023 at 02:59, Gary Gregory wrote: > > Here is the report I plan on filing, probably in the AM (EST): > > ## Descr

Re: [collections] AbstractLinkedList is source incompatible with JDK 21

2023-09-08 Thread Alex Herbert
On Fri, 8 Sept 2023 at 13:46, Alex Herbert wrote: > The problem then becomes how to support AbstractLinkedList and > CursorableLinkedList. Currently collections4 will not be source > compatible with JDK 21. Any downstream project that extends these > classes will not be source com

[collections] AbstractLinkedList is source incompatible with JDK 21

2023-09-08 Thread Alex Herbert
JDK 21 has added these methods to java.util.List: default public void addFirst(E o) default public void addLast(E o) These are source incompatible with Commons Collections AbstractLinkedList: public boolean addFirst(E o) public boolean addLast(E o) This affects AbstractLinkedList and any list t

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
On Wed, 9 Aug 2023 at 17:13, Daniel Watson wrote: > BigSigFig result = new BigSigFig("1.1").multiply(new BigSigFig("2")) Multiply is easy as you take the minimum significant figures. What about addition? 12345 + 0.0001 Here the significant figures should remain at 5. And for this: 12345 + 10

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
On Wed, 9 Aug 2023 at 15:43, Daniel Watson wrote: > > Hope that answers more questions than it creates! It does not address the issue of the last significant zero, e.g: 1 (4 sf) 1 (3 sf) 1 (2 sf) One way to solve this with standard parsing would be to use scientific notation: 1.000

Re: [commons-math] function or Number class to count/track number of significant figures

2023-08-09 Thread Alex Herbert
Hi, On Wed, 9 Aug 2023 at 12:27, Daniel Watson wrote: > This feature is necessary when working with scientific/clinical data which > was reported with significant figures in mind, and for which calculation > results must respect the sigfig count. As far as I could tell there is no > Number imple

Re: [VOTE][LAZY] Release Apache Commons Parent 59 based on RC1

2023-07-24 Thread Alex Herbert
I installed it locally from the git tag. I build the following projects with their default mvn goal using: Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) Maven home: /usr/local/apache-maven-3 Java version: 1.8.0_362, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/

Re: [Pool] Toward version 2.12.0 and 3.0

2023-07-19 Thread Alex Herbert
On Wed, 19 Jul 2023 at 19:38, Gary Gregory wrote: > > OK, that sounds good. > > Gary > > On Tue, Jul 18, 2023 at 5:50 PM Phil Steitz wrote: > > > > I would say 17 for 3.0. > > > > Phil Are there aspects of Pool that require moving away from JDK 8? Such a move would restrict downstream consumers

Re: Move math algorithms from all projects to math libraries

2023-07-18 Thread Alex Herbert
On Tue, 18 Jul 2023 at 09:43, Gilles Sadowski wrote: > > Hello. > > Le mar. 18 juil. 2023 à 02:48, Dimitrios Efthymiou > a écrit : > > > > Thanks Gilles. I checked NUMBERS-193 and i have an implementation of DD and > > i will put it in *.ext package (TBD) along with some tests. Do i have to > > l

Re: Move math algorithms from all projects to math libraries

2023-07-17 Thread Alex Herbert
On Tue, 18 Jul 2023 at 01:48, Dimitrios Efthymiou wrote: > > Thanks Gilles. I checked NUMBERS-193 and i have an implementation of DD and > i will put it in *.ext package (TBD) along with some tests. Do i have to > look at Dfd.java or something, because these dfd classes in math legacy > core have

Re: Are any of these types of projects needed?

2023-07-14 Thread Alex Herbert
I would suggest you develop code that you will use. As volunteers we have a main focus for our interests and put work in where we can, or where it also benefits us back. Contributions of large functionality are typically from an existing project that would like to donate mature code to the ASF. Th

Re: [commons-lang] 02/02: Add IntToIntFunction

2023-07-10 Thread Alex Herbert
Is this not the same as: java.util.function.IntUnaryOperator On Mon, 10 Jul 2023 at 12:56, wrote: > > This is an automated email from the ASF dual-hosted git repository. > > ggregory pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-lang.git > > commit

Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-03 Thread Alex Herbert
On Mon, 3 Jul 2023 at 08:29, sebb wrote: > > Is null checked or unchecked? > > I think neither, so isUnchecked also needs to check for null. > > I wonder whether it might be better to throw NPE in both cases for null. > > It may be confusing for users if not checked != unchecked. > e.g. it is temp

Re: [commons-lang] branch master updated: [LANG-1647] Add and ExceptionUtils.isChecked() and isUnchecked() #1069

2023-07-02 Thread Alex Herbert
This change is not null-safe for isUnchecked. This case is missing from the tests (and currently fails): @Test public void testIsUnchecked_null() { assertFalse(ExceptionUtils.isUnchecked(null)); } The case fails because it simply negates isChecked. Both methods should return f

Re: [COLLECTIONS] Thread safe Bloom filter

2023-07-02 Thread Alex Herbert
I do not think concurrent write usage is a general use case for the filter. So this seems like a specialisation. If implementing it would harm performance then I would be against it for the base implementation. For specialisation I would prefer the JDK pattern used for Synchronized collections whi

Re: [VOTE] Release Apache Commons IO 2.12.0 based on RC2

2023-05-14 Thread Alex Herbert
Built from src zip using: mvn install site Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: /Users/ah403/mvn/mvn Java version: 17.0.6, vendor: Eclipse Adoptium, runtime: /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home Default locale: en_GB, platform encodin

Re: [VOTE] Release Apache Commons IO 2.12.0 based on RC1

2023-05-02 Thread Alex Herbert
Validated signatures and checksums. Build from source tar.gz file using 'mvn verify site' with: Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) Maven home: /usr/local/apache-maven-3 Java version: 11.0.18, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64 Default locale: en

Re: [VOTE] Release Apache Commons Parent 57 based on RC2

2023-04-23 Thread Alex Herbert
+1 Installed from the tag. Builds Statistics (multi-module) and Lang using Java 8 and 17. Note: I do get this error from several plugins (pmd, site, bundle, remote-resources): [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid use of ArtifactRepository type. If you need a

Re: [ALL] Eventually, soon, Java 11

2023-04-23 Thread Alex Herbert
Free commercial support for JDK 8 from Oracle ended in 2022. Non-commercial and extended commercial support ends in 2030. Other providers have free support for longer than 2023 [1]. I would rather maintain Java 8 support when JDK 8 still has broad support and usage. Alex [1] https://en.wikipedia.

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Alex Herbert
Installed from the git tag. I can build projects on JDK 11 and 17. But not on JDK 8. The new profile to conditionally configure the maven-compiler-release plugin for JDK 9+ is incorrect. The parent pom defines the property: 8 Then activates it using: jdk9-compiler

Re: [all] Failed Jenkins builds

2023-03-20 Thread Alex Herbert
On Mon, 20 Mar 2023 at 10:26, Gary Gregory wrote: > > All Commons components are Java 8 (or older), so all could be disabled? I > only rely on GitHub builds since it validates PRs. There is a way to make > releases from GH but I've not looked into it yet. I do not want to waste my time fixing som

[all] Failed Jenkins builds

2023-03-20 Thread Alex Herbert
A recent update in Jenkins has updated some part of the Jenkins tooling that reports on the job to a jar file compiled for Java 11. This is making all the Java 8 Jenkins jobs fail. I am not sure of the relevance of many of these Jenkins builds given the use of GH actions for CI builds. The advanta

[numbers][GSoC2023] About “Add support for extended precision floating-point numbers” project

2023-03-06 Thread Alex Herbert
FYI: I added the [numbers] prefix to the subject line. > > ・ I read David Bailey's paper on the QD library and understood its > > algorithms. I also briefly looked over its C++ implementation. This is where I would start with an API design. E.g. what OO API does the c++ reference implementation

Re: [math] The build is broken

2023-03-04 Thread Alex Herbert
Is it consistently broken? One test for the optimisers requires 15 restarts due to randomness in the optimiser and the difficulty of the optimisation problem. This runs in a different phase. See the surefire plug-in configuration in the math parent pom. We tried to make the test suite more robust

  1   2   3   4   5   6   7   8   9   10   >