[Collections]Several PRs on github need reviews

2019-12-02 Thread Chen Guoping1
Hi all, I'm Chen and I'm new to commons-collections. I like commons-collections cause it provides many useful data structures. I'd like to contribute to it. Last month I pushed several PRs in github : https://github.com/apache/commons-collections/pull/114 https://github.com/apache/commons-coll

Multiple Characters Delimiter

2020-05-09 Thread Chen Guoping1
Hi, everyone Now, on my machine I can simple read and write CSV file which has a multiple characters delimiter like this: And there is a question, I'd like to confirm. The escape character is' \ ', when delimiter is a char ',' printWithEscape print '\,' , so when delimiter is multiple charac

[CSV] Add ignoreEmptyColumnsLines behavior

2020-05-12 Thread Chen Guoping1
Hi, all About Commons CSV [CSV-261](https://issues.apache.org/jira/projects/CSV/issues/CSV-261?filter=allopenissues) Here is a usage scenario that ignores all empty values lines like ",,,\r\n" in the CSV file, This behavior is very useful. So we can consider supporting it in Commons CSV. I hav

[CSV] The Feature Multiple-Character Delimiter

2020-05-12 Thread Chen Guoping1
Hi, all In CSV parsing, there are many scenarios where multiple characters are used as separators, To support this feature, we should change the char type of delimiter to String. This will lead to API changes, and old usage code may need to be modified to pass. When parsing we can ge

Re:Re: [CSV] The Feature Multiple-Character Delimiter

2020-05-13 Thread Chen Guoping1
base or known tool out there that uses such a >format? > >WRT escaping I would think that \ escapes the one character that follows >only. It is up to the reader to decide what to do with an escape sequence. >Anyone else? > >Gary > >On Tue, May 12, 2020 at 7:42 AM Chen Guo

Re:[CSV] The Feature Multiple-Character Delimiter

2020-05-13 Thread Chen Guoping1
rds/iban >> uses \r\n as EOL. >> >> Some of the fields include \n within quoted values. >> > >Chen, > >Are you talking about record separators, field separators, or both? > >Gary > > >> >> > WRT escaping I would think that \ escapes the one

[CSV] Refactor the withXXX methods in CSVFomat by adding a new constructor

2020-05-18 Thread Chen Guoping1
hi, all I found that all the withXXX methods in CSVFomat class need to call the constructor to generate a new CSVFomat object. Once a new format attribute is added, you need to change the call of nearly 30 constructors.May be we can add a map to record all the attributes of CSVFormat class an