Re: [lang] Introduce @NonNull, and @Nullable

I like "javax.annotation namespace" too. Would you be willing to share more about why the annotation dependency should have "provided" scope? If a library (commons-lang) requires a dependency at runtime, I believe it should declare it as "compile" dependency. In past, I did troubleshooting for mis

Re: [lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

Gary, That's a good point. I wasn't thinking about StringUtil's applicability to Object array. On Wed, Mar 11, 2020 at 11:18 AM Gary Gregory wrote: > On Wed, Mar 11, 2020 at 10:24 AM Tomo Suzuki > wrote: > > > (I'm not a commons-lang user) > > Ja

Re: [lang] org.apache.commons.lang3.StringUtils.join(Object[], char) backward

(I'm not a commons-lang user) Java 8 has String.join for the same purpose. https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#join-java.lang.CharSequence-java.lang.CharSequence...- I would deprecate StringUtils.join in favor of String.join. On Wed, Mar 11, 2020 at 10:16 AM Matt Benson

[bcel] Fixing integration build for JDK 13

Hi BCEL maintainers, The JDK 13 travis builds have been failing because of a new behavior of javap command (BCEL-323 ). I raised a PR to fix the build: https://github.com/apache/commons-bcel/pull/31 . I appreciate if you can review/merge this. -- R

Re: [bcel] LRU Cache for ClassPathRepository

if you can review the PR when you have time. Regards, Tomo On Thu, Jun 20, 2019 at 9:29 AM Tomo Suzuki wrote: > Hi Gary and BCEL maintainers, > > I created a PR for LruCacheClassPathRepository > https://github.com/apache/commons-bcel/pull/28 . I appreciate if you can > review t

Re: [bcel] LRU Cache for ClassPathRepository

Hi Gary and BCEL maintainers, I created a PR for LruCacheClassPathRepository https://github.com/apache/commons-bcel/pull/28 . I appreciate if you can review them. Regards, Tomo On Mon, Jun 17, 2019 at 12:11 PM Tomo Suzuki wrote: > Hi Gary and BCEL maintainers, > > My OutOfMemoryErro

[bcel] LRU Cache for ClassPathRepository

pache.org/jira/browse/BCEL-320> A new ClassPathRepository that can scan many JAR files without OutOfMemoryError Test cases to reproduce OutOfMemoryError: https://github.com/suztomo/bcel-oome-example What do you think? Regards, Tomo On Wed, May 22, 2019 at 11:23 AM Tomo Suzuki wrote: &

Re: [bcel] Idea to share ConstantUtf8 of same value among JavaClass instances

Hi Gary and BCEL maintainers, I've added Javadoc for the enhancement. https://github.com/apache/commons-bcel/pull/26 I appreciate if you can check the direction of the implementation is good or bad. Regards, Tomo On Sun, May 19, 2019 at 11:40 PM Tomo Suzuki wrote: > Hi Gary (

Re: [bcel] Idea to share ConstantUtf8 of same value among JavaClass instances

Hi Gary (and BCEL maintainers), Thank you for the comment. It has been addressed. Would you check the pull request? https://github.com/apache/commons-bcel/pull/26/files Regards, Tomo On Wed, May 8, 2019 at 17:46 Tomo Suzuki wrote: > Hi Gary, > Created a draft PR to receive feedback. &

Re: [bcel] Idea to share ConstantUtf8 of same value among JavaClass instances

t; > On Tue, May 7, 2019 at 4:27 PM Tomo Suzuki > wrote: > > > I found the discussion on getInstance method had incurred performance > > degradation https://issues.apache.org/jira/browse/BCEL-186 . > > > > From the JIRA: > > > This feature could return as a pl

Re: [bcel] Idea to share ConstantUtf8 of same value among JavaClass instances

Thu, May 2, 2019 at 1:22 PM Gary Gregory wrote: > On Thu, May 2, 2019 at 10:59 AM Tomo Suzuki > wrote: > > > Gary, > > I didn't find ConstantUtf8.getCachedInstance > > < > https://github.com/apache/commons-bcel/blob/master/src/main/java/org/apache/bcel/classf

Re: [bcel] Idea to share ConstantUtf8 of same value among JavaClass instances

ache/bcel/classfile/ConstantUtf8.java#L123> . Do you know why ConstantUtf8.getCachedInstance is unused? Regards, Tomo On Wed, May 1, 2019 at 7:02 PM Gary Gregory wrote: > On Wed, May 1, 2019 at 6:37 PM Tomo Suzuki > wrote: > > > Gary, > > That’s right. I missed it. I think I

Re: [bcel] Idea to share ConstantUtf8 of same value among JavaClass instances

Gary, That’s right. I missed it. I think I just need to find a way to leverage the getCachedInstance method. Thank you for quick response. On Wed, May 1, 2019 at 18:00 Gary Gregory wrote: > Why not use getCachedInstance() ? > > Gary > > On Wed, May 1, 2019 at 5:20 PM Tomo

[bcel] Idea to share ConstantUtf8 of same value among JavaClass instances

Hi BCEL developers, We use BCEL library to inspect Java class. Thank you for the great library. When our tool checks classes in ~200 jar files, it creates more than 2 million BCEL ConstantUtf8 instances. I suspect many of them share the same values such as "java.lang.String". [image: many_consta