[GitHub] commons-collections issue #54: Replace Clirr with japicmp, since clirr does ...

2018-09-20 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-collections/pull/54 The build produces: ``` [INFO] --- japicmp-maven-plugin:0.12.0:cmp (default-cli) @ commons-collections4 --- [INFO] Skipping execution because parameter 'skip'

[GitHub] commons-collections pull request #54: Replace Clirr with japicmp, since clir...

2018-09-20 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/commons-collections/pull/54 Replace Clirr with japicmp, since clirr does not handle Java 8 defaul… …t methods You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] commons-collections pull request #50: Adopt build matrix from commons-lang

2018-08-23 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/commons-collections/pull/50 Adopt build matrix from commons-lang You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/commons-collections build-matrix

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-15 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/70 Good idea. It's always better to discuss with some acutal code examples at hands. --- - To unsubscribe, e-mail

[GitHub] commons-text issue #70: partial automated migration to assertj

2017-10-15 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/70 Cool! Have missed the discussion about introducing this for Text. I like it. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] commons-io pull request #46: IO-507: Rename ByteOrderUtils class to ByteOrde...

2017-10-14 Thread britter
Github user britter closed the pull request at: https://github.com/apache/commons-io/pull/46 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-io pull request #46: IO-507: Rename ByteOrderUtils class to ByteOrde...

2017-10-13 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/commons-io/pull/46 IO-507: Rename ByteOrderUtils class to ByteOrderParser and remove some logic for parsing strings "big" and "little", after discussions on the ML. You can merge this pul

[GitHub] commons-dbutils issue #2: This is not a real pull request, just give some su...

2017-08-30 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-dbutils/pull/2 The bug tracker is at https://issues.apache.org/jira/browse/DBUTILS. Please see our README.md. If you want to propose changes, please make them minimal and focused (see our CONTRIBUTING.md

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-07-03 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-cli/pull/15 @rubin55 sorry, I'm currently burried in work. Maybe @chtompki or @kinow can have a look? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] commons-cli issue #15: CLI-217: Optional partial matching

2017-07-03 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-cli/pull/15 @rubin55 sorry, I'm currently burried in work. Maybe @chtompki or @kinow can have a look? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] commons-cli pull request #13: CLI-277: Add generics to TypeHandler

2017-06-14 Thread britter
GitHub user britter opened a pull request: https://github.com/apache/commons-cli/pull/13 CLI-277: Add generics to TypeHandler You can merge this pull request into a Git repository by running: $ git pull https://github.com/britter/commons-cli CLI-277 Alternatively you can

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121588869 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121589195 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121589022 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121589195 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121589022 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121588869 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,15 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121493262 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,12 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-12 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121493262 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,12 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-11 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121290023 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,12 @@ public void testURLPattern() throws Exception

[GitHub] commons-cli pull request #12: [CLI-274] implement EXISTING_FILE_VALUE type h...

2017-06-11 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-cli/pull/12#discussion_r121290023 --- Diff: src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java --- @@ -159,13 +161,12 @@ public void testURLPattern() throws Exception

[GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...

2017-06-08 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-text/pull/45#discussion_r121055613 --- Diff: .travis.yml --- @@ -21,8 +21,15 @@ jdk: - oraclejdk7 - oraclejdk8 +services: + - docker + +before_install

[GitHub] commons-cli issue #3: [CLI-253] Prevent "Unrecognized option: --null" when h...

2017-06-08 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-cli/pull/3 @msrb we hat a change in our git infrastructure. Can you please reopen this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] commons-cli issue #10: [CLI-274] implement EXISTING_FILE_VALUE type handler

2017-06-08 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-cli/pull/10 @schaumb we had a change in our Git infrastructure which caused the asfgit bot to close this PR. can you please reopen it? Thank you! --- If your project is set up for it, you can reply to this

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

2017-06-08 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/44 @chtompki this indicates a source incompatible release. Binary compatible means that you can swap out the 1.1 jar with the 1.2 jar without a recompile. Would that work? I can't r

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

2017-06-08 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/44 @ameyjadiye the best would be to rebase your branch against master an dann do a force push. You can do it like this (if you have configured this repository as remote with name upstream

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

2017-06-07 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/44 @chtompki did you run chirr manually? Because it was checkstyle which caused the Travis build to fail (trailing white spaces). I think this change should not break BC. @ameyjadiye can you

[GitHub] commons-text issue #44: [TEXT-80]: Fixed confusing StrLookup API

2017-06-05 Thread britter
Github user britter commented on the issue: https://github.com/apache/commons-text/pull/44 LGTM, @chtompki what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

commons-text git commit: Remove last evidence that the code for the site has been stolen from Commons Lang

2014-11-11 Thread britter
Repository: commons-text Updated Branches: refs/heads/master 750beb923 -> 71b59af90 Remove last evidence that the code for the site has been stolen from Commons Lang Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-text/

commons-text git commit: Bootstrap commons-text component

2014-11-11 Thread britter
ox/commons-text/ + + +jira +http://issues.apache.org/jira/browse/SANDBOX + + + + scm:git:http://git-wip-us.apache.org/repos/asf/commons-text.git + scm:git:https://git-wip-us.apache.org/repos/asf/commons-text.git +https://git-wip-us.apache.org/repos/asf?p=commons-text