Re: [5/6] [math] Fixed findbugs warning.

2015-11-04 Thread Gilles
On Wed, 04 Nov 2015 14:14:53 +0100, luc wrote: Le 2015-11-04 13:44, Gilles a écrit : On Tue, 03 Nov 2015 18:07:50 +0100, Luc Maisonobe wrote: Le 03/11/2015 15:33, Gilles a écrit : On Tue, 03 Nov 2015 11:06:50 -, l...@apache.org wrote: Fixed findbugs warning. When defining compareTo, we

Re: [5/6] [math] Fixed findbugs warning.

2015-11-04 Thread Gilles
On Tue, 03 Nov 2015 18:07:50 +0100, Luc Maisonobe wrote: Le 03/11/2015 15:33, Gilles a écrit : On Tue, 03 Nov 2015 11:06:50 -, l...@apache.org wrote: Fixed findbugs warning. When defining compareTo, we should also define equals and hashcode. Project:

Re: [5/6] [math] Fixed findbugs warning.

2015-11-04 Thread Gilles
On Wed, 04 Nov 2015 14:20:55 +0100, Gilles wrote: [...] But it was perhaps a bad design choice to have "PairNeuronDouble" implement "Comparable". I propose to use an explicit "Comparator" in order to fix the problem. Good idea! I have done it and pushed it on both master and MATH_3_X

Re: [5/6] [math] Fixed findbugs warning.

2015-11-04 Thread luc
Le 2015-11-04 14:34, Gilles a écrit : On Wed, 04 Nov 2015 14:20:55 +0100, Gilles wrote: [...] But it was perhaps a bad design choice to have "PairNeuronDouble" implement "Comparable". I propose to use an explicit "Comparator" in order to fix the problem. Good idea! I have done it and

Re: [5/6] [math] Fixed findbugs warning.

2015-11-04 Thread luc
Le 2015-11-04 13:44, Gilles a écrit : On Tue, 03 Nov 2015 18:07:50 +0100, Luc Maisonobe wrote: Le 03/11/2015 15:33, Gilles a écrit : On Tue, 03 Nov 2015 11:06:50 -, l...@apache.org wrote: Fixed findbugs warning. When defining compareTo, we should also define equals and hashcode.

Re: [5/6] [math] Fixed findbugs warning.

2015-11-03 Thread Luc Maisonobe
Le 03/11/2015 15:33, Gilles a écrit : > On Tue, 03 Nov 2015 11:06:50 -, l...@apache.org wrote: >> Fixed findbugs warning. >> >> When defining compareTo, we should also define equals and hashcode. >> >> >> Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo >> Commit: >>

Re: [5/6] [math] Fixed findbugs warning.

2015-11-03 Thread Gilles
On Tue, 03 Nov 2015 11:06:50 -, l...@apache.org wrote: Fixed findbugs warning. When defining compareTo, we should also define equals and hashcode. Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/04454fc0