Re: [COMPRESS] Help needed to fix COMPRESS-651

2024-03-09 Thread Gary Gregory
Thank you Peter for the patch. Now in git master. As to whether we should change the default, I don't know if we have the right kind of test that would detect if changing the default causes a problem. Changing the default to true (locally) causes the build to XXX but that does not mean we have

Re: [COMPRESS] Help needed to fix COMPRESS-651

2024-03-09 Thread Gary Gregory
Thanks for the reminder, Peter. That rings a bell... vaguely. Can this test pass by configuring the input stream differently? Gary On Sat, Mar 9, 2024 at 1:21 PM Peter Hull wrote: > > On Sat, 9 Mar 2024 at 14:33, Gary Gregory wrote: > > > > If you want to help in Commons COMPRESS-land, please

Re: [COMPRESS] Help needed to fix COMPRESS-651

2024-03-09 Thread Peter Hull
On Sat, 9 Mar 2024 at 18:19, Peter Hull wrote: > There's another constructor for BZip2CompressorInputStream which > allows for this, it's not the default. Specifically, the patch below makes the test pass. Whether this should be default for the one-arg constructor is a matter for discussion.

Re: [COMPRESS] Help needed to fix COMPRESS-651

2024-03-09 Thread Peter Hull
On Sat, 9 Mar 2024 at 14:33, Gary Gregory wrote: > > If you want to help in Commons COMPRESS-land, please see > https://issues.apache.org/jira/browse/COMPRESS-651 I swear I looked into this a while ago, and the issue was pbzip2 works by compressing the source in chunks, in parallel, then cat'ing

[COMPRESS] Help needed to fix COMPRESS-651

2024-03-09 Thread Gary Gregory
If you want to help in Commons COMPRESS-land, please see https://issues.apache.org/jira/browse/COMPRESS-651 TY, Gary - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: