RE: [CONFIGURATION] Formatting braces

2019-09-13 Thread Mark Roberts
That's exactly what we do with all our projects here at UW/PLSE. Mark -Original Message- From: James Ring [mailto:s...@jdns.org] Sent: Friday, September 13, 2019 6:44 AM To: Commons Developers List Subject: Re: [CONFIGURATION] Formatting braces What about https://github.com/google

Re: [CONFIGURATION] Formatting braces

2019-09-13 Thread James Ring
What about https://github.com/google/google-java-format ? Just require that it be run on check-in, all these style questions go away (as a bonus, it looks nice too). On Wed, Sep 11, 2019 at 6:54 AM Gary Gregory wrote: > > Hi All: > > I only hope that this will not turn into a bike shedding

Re: [CONFIGURATION] Formatting braces

2019-09-13 Thread Gary Gregory
On Thu, Sep 12, 2019 at 1:11 PM Thomas Vandahl wrote: > On 11.09.19 15:53, Gary Gregory wrote: > > public static final ConfigurationConsumer > > DEFAULT_INCLUDE_LISTENER = e -> { throw e; }; > > > > public static final ConfigurationConsumer > > NOOP_INCLUDE_LISTENER = e -> { /* noop */

Re: [CONFIGURATION] Formatting braces

2019-09-12 Thread Thomas Vandahl
On 11.09.19 15:53, Gary Gregory wrote: > public static final ConfigurationConsumer > DEFAULT_INCLUDE_LISTENER = e -> { throw e; }; > > public static final ConfigurationConsumer > NOOP_INCLUDE_LISTENER = e -> { /* noop */ }; +1 for these. > I propose a reformatting to use the "{ on the

Re: [CONFIGURATION] Formatting braces

2019-09-11 Thread sebb
On Wed, 11 Sep 2019 at 15:15, Gary Gregory wrote: > > On Wed, Sep 11, 2019 at 10:12 AM Gilles Sadowski > wrote: > > > Hello. > > > > +1 > > > > Le mer. 11 sept. 2019 à 15:54, Gary Gregory a > > écrit : > > > > > > Hi All: > > > > > > I only hope that this will not turn into a bike shedding

Re: [CONFIGURATION] Formatting braces

2019-09-11 Thread Gary Gregory
On Wed, Sep 11, 2019 at 10:12 AM Gilles Sadowski wrote: > Hello. > > +1 > > Le mer. 11 sept. 2019 à 15:54, Gary Gregory a > écrit : > > > > Hi All: > > > > I only hope that this will not turn into a bike shedding thread... > > A uniform coding style (for all components); that *seems* obvious

Re: [CONFIGURATION] Formatting braces

2019-09-11 Thread Gilles Sadowski
Hello. +1 Le mer. 11 sept. 2019 à 15:54, Gary Gregory a écrit : > > Hi All: > > I only hope that this will not turn into a bike shedding thread... A uniform coding style (for all components); that *seems* obvious (too)... Gilles > > Commons Configuration is one of the few components we have

[CONFIGURATION] Formatting braces

2019-09-11 Thread Gary Gregory
Hi All: I only hope that this will not turn into a bike shedding thread... Commons Configuration is one of the few components we have that uses the formatting rule (enforced by Checkstyle) where braces must be on separate lines. In the age of lambdas, this is, IMO, lame (a technical term ;-) for