Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-19 Thread sebb
On 19 March 2013 20:45, Oliver Heger wrote: > Am 18.03.2013 11:19, schrieb sebb: > >> On 18 March 2013 10:07, Benedikt Ritter wrote: >>> >>> 2013/3/18 sebb >>> The new utils.mime classes for MIME decoding are mostly package-protected. However, they have public methods (and ct

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-19 Thread Oliver Heger
Am 18.03.2013 11:19, schrieb sebb: On 18 March 2013 10:07, Benedikt Ritter wrote: 2013/3/18 sebb The new utils.mime classes for MIME decoding are mostly package-protected. However, they have public methods (and ctors) which is a bit misleading. I think it would make sense to reduce the vis

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread Gary Gregory
+1 Gary On Mar 18, 2013, at 6:20, sebb wrote: > On 18 March 2013 10:07, Benedikt Ritter wrote: >> 2013/3/18 sebb >> >>> The new utils.mime classes for MIME decoding are mostly package-protected. >>> >>> However, they have public methods (and ctors) which is a bit misleading. >>> >>> I think i

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread Simone Tripodi
> The new utils.mime classes for MIME decoding are mostly package-protected. > > However, they have public methods (and ctors) which is a bit misleading. > > I think it would make sense to reduce the visibility to package protected. > > Any objections? > No objections http://people.apache.org/~si

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread Benedikt Ritter
2013/3/18 sebb > On 18 March 2013 10:07, Benedikt Ritter wrote: > > 2013/3/18 sebb > > > >> The new utils.mime classes for MIME decoding are mostly > package-protected. > >> > >> However, they have public methods (and ctors) which is a bit misleading. > >> > >> I think it would make sense to re

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread sebb
On 18 March 2013 10:07, Benedikt Ritter wrote: > 2013/3/18 sebb > >> The new utils.mime classes for MIME decoding are mostly package-protected. >> >> However, they have public methods (and ctors) which is a bit misleading. >> >> I think it would make sense to reduce the visibility to package prot

Re: [FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread Benedikt Ritter
2013/3/18 sebb > The new utils.mime classes for MIME decoding are mostly package-protected. > > However, they have public methods (and ctors) which is a bit misleading. > > I think it would make sense to reduce the visibility to package protected. > > Any objections? > I personally don't align v

[FILEUPLOAD] Package protected classes have public methods - make these package protected?

2013-03-18 Thread sebb
The new utils.mime classes for MIME decoding are mostly package-protected. However, they have public methods (and ctors) which is a bit misleading. I think it would make sense to reduce the visibility to package protected. Any objections?