[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-collections/pull/33 [![Coverage Status](https://coveralls.io/builds/14052842/badge)](https://coveralls.io/builds/14052842) Coverage increased (+0.006%) to 86.622% when pulling **3ee56fdce999b

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/commons-collections/pull/33 Hello, @kinow, Could you please take a look on this PR? Thanks! --- - To unsubscribe, e-mail: dev-unsubscr...@com

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/commons-collections/pull/33 The CI error seems does not relevant to this PR. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/33 Hi @zhangminglei ! Sure. Few questions from reviewing the JIRA ticket and the pull request. * Why Commons Collections? The SortedProperties uses Java collection classes to

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/commons-collections/pull/33 Hello, @kinow Thanks for your reply! - Why Commons Collections?. I am not sure which is the best address I should put it. At the beginning, I created the JIRA under Commons

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-collections/pull/33 Thanks for the clear response Minglei! And thanks for your contribution. Let's see what others think :+1: --- - To uns

[GitHub] commons-collections issue #33: [COLLECTIONS-664] Add a class that extend a l...

2017-11-06 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/commons-collections/pull/33 Thanks @kinow . I would move this PR to Commons/Configuration. I just not sure which component is the best to put it. --- --