Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
For detailed explanation.
Github user ecki commented on the issue:
https://github.com/apache/commons-text/pull/49
Not sure I understand the question, surrogate Pairs only exist in UTF-16.
UTF-8 uses a multi byte encoding for code points outside the BMP and UTF-32
uses 4 bytes (and skips the high/low surrogate
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
Okay I don't mind to change but what does UTF-16 with surrogate pairs
support? Why did we do this refactoring?
---
If your project is set up for it, you can reply to this email and have
Github user ecki commented on the issue:
https://github.com/apache/commons-text/pull/49
It does not provide support for UTF-32 (which is a 4 byte encoding not
implemented in the patch) but it provides support for UTF-16 surrogate pairs
(1..2 x 2bytes). The both encodings are not
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
probably just because utf-32 it could be confusing, @ecki can explain more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
Not sure why I should change the PR name? I never mentioned it provides
native support for UTF-32 and it clearly states support using surrogate pairs .
---
If your project is set up for
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
@arunvinudss , can you please rename PR saying character processing
switched with codepoints and change commit comment as well, that you can do
with ```rebase``` or ```git commit --amend```
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
Ordering of import has changed as all the similar packages were grouped
together. It was not intended I believe my IDE did that automatically. I see
other test classes using wild card
Github user jbduncan commented on the issue:
https://github.com/apache/commons-text/pull/49
It's not clear to me why the ordering of the imports has changed and why
all the `assert*()` method imports have been replaced with a wildcard import.
Are those intentional?
---
If your
Github user ecki commented on the issue:
https://github.com/apache/commons-text/pull/49
It still uses missleading UTF-32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ameyjadiye commented on the issue:
https://github.com/apache/commons-text/pull/49
@chtompki , this PR looks good, shall we merge it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
@ecki I agree and thats the best we can do for now to support UTF-32 .
Thanks for the input ð
---
If your project is set up for it, you can reply to this email and have your
reply
12 matches
Mail list logo
