+1. This is so trivial that it doesn't pass the threshold of originality.
LieGrue,
strub
> Am 19.11.2018 um 18:15 schrieb Mark Thomas :
>
> I'd image the comment is referring to the use of "... & 0xFF" but it
> seems to be a fairly pointless comment as that is just the standard way
> to switch f
On Tue, Nov 20, 2018 at 8:31 AM Sharon Corbett <
sharon.corb...@eclipse-foundation.org> wrote:
> Thanks for the quick investigation and response.
>
> It's appreciated!
>
You're welcome Sharon.
I removed the comment in commit b487c9e8bc8410c7c0ca94f9494bcff90613946a
Gary
>
> Regards,
> Sharon
Thanks for the quick investigation and response.
It's appreciated!
Regards,
Sharon
On Mon, Nov 19, 2018 at 4:36 PM Gary Gregory wrote:
> Hi All:
>
> I agree that the 0xff usage does not need to be documented, and while I do
> see it used in ByteArrayInputStream#read() in Oracle Java 6, I rea
Hi All:
I agree that the 0xff usage does not need to be documented, and while I do
see it used in ByteArrayInputStream#read() in Oracle Java 6, I really do
not think we need to refer to it.
I am +1 to removing the comment. Who will do the honors?
Gary
On Mon, Nov 19, 2018 at 10:15 AM Mark Thoma
I'd image the comment is referring to the use of "... & 0xFF" but it
seems to be a fairly pointless comment as that is just the standard way
to switch from signed byte to 'unsigned' int values.
I can't see what else it could possibly be referring to.
I don't see any IP issue here.
I'd suggest si
Hi everybody,
the code is from a pull request which I merged:
https://github.com/apache/commons-io/pull/8
I did not author the code.
The comment seems incorrect because I do not think there is a field
"repeatedContent" in java.io.ByteArrayInputStream. The current OpenJDK
implementation looks
Hi All and Pascal S.,
Sharon (Eclipse) has pointed out to me that
in org.apache.commons.io.input.InfiniteCircularInputStream.read() [1], we
have:
@Override
public int read() {
position = (position + 1) % repeatedContent.length;
return repeatedContent[position] & 0xff; // c
