Re: [IO] Robust file remover, other Windows-specific enhancements

2018-12-26 Thread Matt Sicker
https://github.com/apache/commons-io/pull/72 for the PR. On Sat, 22 Dec 2018 at 10:16, Gary Gregory wrote: > Nice :-) > > On Fri, Dec 21, 2018, 11:11 Matt Sicker > > I like that idea. I'll reorganize some code from the Jenkins PR into a > one > > for IO. > > > > On Fri, 21 Dec 2018 at 11:51, Ga

Re: [IO] Robust file remover, other Windows-specific enhancements

2018-12-22 Thread Gary Gregory
Nice :-) On Fri, Dec 21, 2018, 11:11 Matt Sicker I like that idea. I'll reorganize some code from the Jenkins PR into a one > for IO. > > On Fri, 21 Dec 2018 at 11:51, Gary Gregory wrote: > > > That could go in Commons IO, sure. > > > > I would prefer the code to go in a focused class like a Del

Re: [IO] Robust file remover, other Windows-specific enhancements

2018-12-21 Thread Matt Sicker
I like that idea. I'll reorganize some code from the Jenkins PR into a one for IO. On Fri, 21 Dec 2018 at 11:51, Gary Gregory wrote: > That could go in Commons IO, sure. > > I would prefer the code to go in a focused class like a DeleteUtils or > DeleteFiles. It might also be neat to make the cl

Re: [IO] Robust file remover, other Windows-specific enhancements

2018-12-21 Thread Matt Sicker
After looking through the open issues and PRs for IO, I don't see anything similar, though there is https://issues.apache.org/jira/browse/IO-295 which may be related to junctions as well. This may also be a nice opportunity to introduce a PathUtils class similar to FileUtils since IO already uses J

Re: [IO] Robust file remover, other Windows-specific enhancements

2018-12-21 Thread Gary Gregory
That could go in Commons IO, sure. I would prefer the code to go in a focused class like a DeleteUtils or DeleteFiles. It might also be neat to make the class instantiable and configurable instead of having lots of options args. Gary On Fri, Dec 21, 2018, 09:58 Matt Sicker I've been refactoring

[IO] Robust file remover, other Windows-specific enhancements

2018-12-21 Thread Matt Sicker
I've been refactoring some IO code in Jenkins lately that are similar to the FileUtils delete family of methods. I had originally wanted to replace them with calls to FileUtils, but I noticed that we had a more sophisticated strategy for retrying deletes and other workarounds for (usually) Windows-