Re: [LANG] travis build failures

2018-02-28 Thread Matt Sicker
For a flaky test like this, perhaps running it N times and asserting that it passes ~N-1 iterations? On 28 February 2018 at 12:00, Otto Fowler wrote: > As long as it is the pr that fails, or that someone with rights to > re-trigger apache travis > notices and restarts the build. > > > On Februar

Re: [LANG] travis build failures

2018-02-28 Thread Otto Fowler
As long as it is the pr that fails, or that someone with rights to re-trigger apache travis notices and restarts the build. On February 28, 2018 at 12:39:03, Gilles (gil...@harfang.homelinux.org) wrote: Hi. On Wed, 28 Feb 2018 08:49:42 +0200, Allon Mureinik wrote: > An alternative approach coul

Re: [LANG] travis build failures

2018-02-28 Thread Gilles
Hi. On Wed, 28 Feb 2018 08:49:42 +0200, Allon Mureinik wrote: An alternative approach could be to remove the randomness from the test by using a predefined random seed and test the overloaded variants that accept a second java.util.Random argument. This will superficially reduce the test's cov

Re: [LANG] travis build failures

2018-02-27 Thread Allon Mureinik
An alternative approach could be to remove the randomness from the test by using a predefined random seed and test the overloaded variants that accept a second java.util.Random argument. This will superficially reduce the test's coverage, but it does have a reliability advantage, IMHO (as seen in O

Re: [LANG] travis build failures

2018-02-27 Thread Gary Gregory
Of course... but how would test then? Shuffle N times and accept a % of non-shuffles? Gary On Tue, Feb 27, 2018, 13:18 Allon Mureinik wrote: > There will still be a chance, however infinitesimal, of a failure. :-) > > > On Tue, Feb 27, 2018 at 9:02 PM, Gary Gregory > wrote: > > > Why not make

Re: [LANG] travis build failures

2018-02-27 Thread Allon Mureinik
There will still be a chance, however infinitesimal, of a failure. :-) On Tue, Feb 27, 2018 at 9:02 PM, Gary Gregory wrote: > Why not make the array 1000 items long? > > Gary > > On Tue, Feb 27, 2018 at 10:31 AM, Allon Mureinik > wrote: > > > All the ArrayUtilsTest#testShuffleXYZ tests take an

Re: [LANG] travis build failures

2018-02-27 Thread Gary Gregory
Why not make the array 1000 items long? Gary On Tue, Feb 27, 2018 at 10:31 AM, Allon Mureinik wrote: > All the ArrayUtilsTest#testShuffleXYZ tests take an array, shuffle it, and > assert that the result isn't equal to the original array. > This is usually true, but there's a small chance that t

Re: [LANG] travis build failures

2018-02-27 Thread Allon Mureinik
All the ArrayUtilsTest#testShuffleXYZ tests take an array, shuffle it, and assert that the result isn't equal to the original array. This is usually true, but there's a small chance that the shuffled array will be equal to the original array, and thus the test will fail. This chance is higher for t

Re: [LANG] travis build failures

2018-02-27 Thread Otto Fowler
Note, this does pass in my personal travis: https://travis-ci.org/ottobackwards/commons-lang/builds/346806991 On February 27, 2018 at 11:58:24, Otto Fowler (ottobackwa...@gmail.com) wrote: My PR is currently failing for java 9 on this test. Anyone have any idea why? [INFO] Running org.apache.c

[LANG] travis build failures

2018-02-27 Thread Otto Fowler
My PR is currently failing for java 9 on this test. Anyone have any idea why? [INFO] Running org.apache.commons.lang3.ArrayUtilsTest [ERROR] Tests run: 307, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.114 s <<< FAILURE! - in org.apache.commons.lang3.ArrayUtilsTest [ERROR] testShuffleBoole