Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-21 Thread Gary Gregory
I also fixed the test on Java 11. Gary On Sun, Sep 20, 2020 at 3:27 PM Gary Gregory wrote: > While I fixed the bug and the build passes on Java 8 for me, it does not > on Java 11. This could be an issue in the test itself or between the test > and the Apache Mina FTP server embedded in the test

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-20 Thread Gary Gregory
While I fixed the bug and the build passes on Java 8 for me, it does not on Java 11. This could be an issue in the test itself or between the test and the Apache Mina FTP server embedded in the test. I'd like to release (or someone else) 3.7.1 to fix the regression in FTPS. javax.net.ssl.SSLHands

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-20 Thread Gary Gregory
I fixed the bug in master and provided a test. Gary On Fri, Sep 18, 2020, 06:03 sebb wrote: > On Thu, 17 Sep 2020 at 16:39, Gary Gregory > wrote: > > > > On Thu, Sep 17, 2020 at 6:47 AM sebb wrote: > > > > > > Does VFS actually *need* the latest version of NET? > > > > Sigh, that's irrelevan

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-18 Thread sebb
On Thu, 17 Sep 2020 at 16:39, Gary Gregory wrote: > > On Thu, Sep 17, 2020 at 6:47 AM sebb wrote: > > > > Does VFS actually *need* the latest version of NET? > > Sigh, that's irrelevant as you can't control downstream stacks. This > is a regression from the user's point of view. OK, I see now.

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-17 Thread Gary Gregory
I can confirm that PR https://github.com/apache/commons-net/pull/59 fixes the regressing bug in Apache Commons VFS master tests in **org.apache.commons.vfs2.provider.ftps.test** which was introduced by Commons Net 3.7. The PR does not have a test though. Gary On Thu, Sep 17, 2020 at 12:14 PM Gar

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-17 Thread Gary Gregory
Connecting dots FTR: https://issues.apache.org/jira/browse/NET-687 On Fri, Sep 11, 2020 at 9:46 AM Gary Gregory wrote: > > Hi All: > > Updating Commons VFS from Commons Net 3.6 to 3.7 causes failures. Please see: > > https://github.com/apache/commons-vfs/pull/128 > > For example: > > https://gith

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-17 Thread Gary Gregory
On Thu, Sep 17, 2020 at 6:47 AM sebb wrote: > > Does VFS actually *need* the latest version of NET? Sigh, that's irrelevant as you can't control downstream stacks. This is a regression from the user's point of view. > i.e. does it fix a bug or a security issue that impacts VFS? I hope that's a

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-17 Thread sebb
Does VFS actually *need* the latest version of NET? i.e. does it fix a bug or a security issue that impacts VFS? If not, then downdate until such time as the issue can be fixed. It would be helpful to have a simple test case that shows the issue. On Tue, 15 Sep 2020 at 14:08, Gary Gregory wrote

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-15 Thread Gary Gregory
Is anyone available to help? Gary On Sat, Sep 12, 2020 at 3:53 PM Gary Gregory wrote: > > The culprit commit seems to be 41e514cda5f68c444edc1058a18e2196b2c1d7d5. > If I checkout the commit before that one, all is well with the FTPS > tests in Commons VFS master. > The fundamental problem is tha

Re: [VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-12 Thread Gary Gregory
The culprit commit seems to be 41e514cda5f68c444edc1058a18e2196b2c1d7d5. If I checkout the commit before that one, all is well with the FTPS tests in Commons VFS master. The fundamental problem is that there is not a single test for the class FTPSClient, so all commits against that class are "blind

[VFS][NET] Failures when updating VFS from Net 3.6 to 3.7

2020-09-11 Thread Gary Gregory
Hi All: Updating Commons VFS from Commons Net 3.6 to 3.7 causes failures. Please see: https://github.com/apache/commons-vfs/pull/128 For example: https://github.com/apache/commons-vfs/pull/128/checks?check_run_id=1100197771 Any thoughts? Tests in error: 695 AbstractFtpsProviderTestCase$FtpPr