Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Gary Gregory
That would be a typo, I meant Alex, sorry for the confusion. Gary On Sun, Apr 23, 2023, 14:24 Markus Spann wrote: > Who's Albert? > > > Am 23. April 2023 13:33:23 UTC schrieb Gary Gregory < > garydgreg...@gmail.com>: > >> Thank you for reviewing Albert. Wow! What a fail on the part of the >> m

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Gary Gregory
On Sun, Apr 23, 2023 at 4:03 AM Alex Herbert wrote: > Other notes: > > 1. I still get a warning from the SPDX plugin (same as previous versions of > CP): > > [WARNING] Unable to map maven licenses to a declared license. Using > NOASSERTION > > I do not know where this comes from. The ASF 2.0 l

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Gary Gregory
IMO the name jvm.target is incorrect because it is not the JVM that is the target it is the JRE API. Gary On Sun, Apr 23, 2023 at 4:03 AM Alex Herbert wrote: > > Installed from the git tag. I can build projects on JDK 11 and 17. But > not on JDK 8. > > The new profile to conditionally configure

[CANCEL][VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Gary Gregory
This vote for RC1 is canceled (see below). Gary On Sun, Apr 23, 2023 at 9:33 AM Gary Gregory wrote: > > Thank you for reviewing Albert. Wow! What a fail on the part of the > maven compiler plugin! :-( I thought for sure I had tested that but I > obviously fooled myself. > > I created https://iss

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Gary Gregory
Thank you for reviewing Albert. Wow! What a fail on the part of the maven compiler plugin! :-( I thought for sure I had tested that but I obviously fooled myself. I created https://issues.apache.org/jira/browse/MCOMPILER-534 I will cancel this RC. Gary On Sun, Apr 23, 2023 at 4:03 AM Alex Herbe

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-23 Thread Alex Herbert
Installed from the git tag. I can build projects on JDK 11 and 17. But not on JDK 8. The new profile to conditionally configure the maven-compiler-release plugin for JDK 9+ is incorrect. The parent pom defines the property: 8 Then activates it using: jdk9-compiler

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-22 Thread Gary Gregory
Most of our components are single module and you don't have to use our components to make releases, so I am not sure what there is to exclude or what you propose as the alternative. I've been making releases including the multiple module Commons VFS and it works for me. Maybe you can propose a conc

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-22 Thread Thomas Vandahl
Hi Gary, > Am 22.04.2023 um 16:24 schrieb Gary Gregory >: > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Parent 56 was released, so I would like to > release Apache Commons Parent 57. > Can we please make the com

Re: [VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-22 Thread Thomas Vandahl
Hi Gary, > Am 22.04.2023 um 16:24 schrieb Gary Gregory : > > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons Parent 56 was released, so I would like to > release Apache Commons Parent 57. > Can we please make the commons-release-plugin an optional c

[VOTE][LAZY] Release Apache Commons Parent 57 based on RC1

2023-04-22 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons Parent 56 was released, so I would like to release Apache Commons Parent 57. Apache Commons Parent 57 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/commons-parent/57-R