Re: [CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Gilles
On Wed, 8 Aug 2018 12:06:18 -0400, Rob Tompkins wrote: On Aug 8, 2018, at 10:26 AM, Gilles wrote: On Wed, 8 Aug 2018 08:00:11 -0600, Gary Gregory wrote: Oh and you should consider marking the API we are adding back as @deprecated. ? There is no replacement. [I've tried to explain the issue

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Gilles
On Wed, 8 Aug 2018 12:04:58 -0400, Rob Tompkins wrote: On Aug 8, 2018, at 9:59 AM, Gary Gregory wrote: Thank you Rob! If there are any BC breakage at all left, please note why they are there and why they are ok in the release notes. Yes. that makes sense to me. It's already there! Gille

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Rob Tompkins
> On Aug 8, 2018, at 10:26 AM, Gilles wrote: > > On Wed, 8 Aug 2018 08:00:11 -0600, Gary Gregory wrote: >> Oh and you should consider marking the API we are adding back as >> @deprecated. > > ? > There is no replacement. > [I've tried to explain the issue in a previous message.] We can state

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Rob Tompkins
> On Aug 8, 2018, at 9:59 AM, Gary Gregory wrote: > > Thank you Rob! If there are any BC breakage at all left, please note why > they are there and why they are ok in the release notes. Yes. that makes sense to me. -Rob > > Gary > > On Wed, Aug 8, 2018, 07:48 Rob Tompkins wrote: > >> I

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Gilles
On Wed, 8 Aug 2018 08:00:11 -0600, Gary Gregory wrote: Oh and you should consider marking the API we are adding back as @deprecated. ? There is no replacement. [I've tried to explain the issue in a previous message.] Gilles Gary On Wed, Aug 8, 2018, 07:48 Rob Tompkins wrote: I am cancelli

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Gary Gregory
Oh and you should consider marking the API we are adding back as @deprecated. Gary On Wed, Aug 8, 2018, 07:48 Rob Tompkins wrote: > I am cancelling this vote because I personally would vote -1 on this RC. > Many thanks to those that looked at RC6. > > Cheers, > -Rob > > > On Aug 7, 2018, at 9:4

Re: [CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Gary Gregory
Thank you Rob! If there are any BC breakage at all left, please note why they are there and why they are ok in the release notes. Gary On Wed, Aug 8, 2018, 07:48 Rob Tompkins wrote: > I am cancelling this vote because I personally would vote -1 on this RC. > Many thanks to those that looked at

[CANCEL][VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Rob Tompkins
I am cancelling this vote because I personally would vote -1 on this RC. Many thanks to those that looked at RC6. Cheers, -Rob > On Aug 7, 2018, at 9:42 AM, Rob Tompkins wrote: > > We have added some significant enhancements since Apache Commons RNG 1.0 was > released, so I would like to rele

Re: [VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-08 Thread Gilles
Hi. On Tue, 7 Aug 2018 21:44:05 -0400, Rob Tompkins wrote: On Aug 7, 2018, at 9:25 PM, Gilles wrote: On Tue, 7 Aug 2018 18:48:40 -0600, Gary Gregory wrote: Hi All, Let me rephrase the question: Is the change part of what RNG considers its public API? The first Clirr error was settled, a

Re: [VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-07 Thread Rob Tompkins
> On Aug 7, 2018, at 9:25 PM, Gilles wrote: > >> On Tue, 7 Aug 2018 18:48:40 -0600, Gary Gregory wrote: >> Hi All, >> >> Let me rephrase the question: Is the change part of what RNG considers its >> public API? > > The first Clirr error was settled, as noted in the JIRA ticket. > >> If yes,

Re: [VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-07 Thread Gilles
On Tue, 7 Aug 2018 18:48:40 -0600, Gary Gregory wrote: Hi All, Let me rephrase the question: Is the change part of what RNG considers its public API? The first Clirr error was settled, as noted in the JIRA ticket. If yes, the we must not break BC in a minor release. 1.1 should be a drop i

Re: [VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-07 Thread Gary Gregory
Hi All, Let me rephrase the question: Is the change part of what RNG considers its public API? If yes, the we must not break BC in a minor release. 1.1 should be a drop in replacement to 1.0 and not cause a runtime error. Gary On Tue, Aug 7, 2018 at 4:46 PM Gilles wrote: > Hi. > > On Tue, 7

Re: [VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-07 Thread Gilles
Hi. On Tue, 7 Aug 2018 15:11:30 -0600, Gary Gregory wrote: Hi All: Is this failure expected: [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ commons-rng-sampling --- [INFO] Comparing to version: 1.0 [ERROR] 5001: org.apache.commons.rng.sampling.distribution.BoxMullerLogNormalSampler:

Re: [VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-07 Thread Gary Gregory
Hi All: Is this failure expected: [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ commons-rng-sampling --- [INFO] Comparing to version: 1.0 [ERROR] 5001: org.apache.commons.rng.sampling.distribution.BoxMullerLogNormalSampler: Removed org.apache.commons.rng.sampling.distribution.SamplerBas

[VOTE] Release Apache Commons RNG 1.1 based on RC6

2018-08-07 Thread Rob Tompkins
We have added some significant enhancements since Apache Commons RNG 1.0 was released, so I would like to release Apache Commons RNG 1.1. Apache Commons RNG 1.1 RC6 is available for review here: https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC6 (svn revision 28595, site 28596) Th