[VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Stian Soiland-Reyes
This is a [VOTE] for releasing Apache Commons BeanUtils 1.9.3 (from RC2) SVN tag: https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/BEANUTILS_1_9_3_RC2/ Site: https://stain.github.io/commons-beanutils/1.9.3-rc2/ Javadoc: https://stain.github.io/commons-beanutils/1.9.3-rc2/ap

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Raviteja Lokineni
Why do the distribution files hashes have commons-rng? On Wed, Sep 14, 2016 at 11:45 AM, Stian Soiland-Reyes wrote: > This is a [VOTE] for releasing Apache Commons BeanUtils 1.9.3 (from RC2) > > > SVN tag: > https://svn.apache.org/repos/asf/commons/proper/beanutils/ > tags/BEANUTILS_1_9_3_RC2/

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Gary Gregory
Curious: what does "Semantic Versioning: 0.0.1" mean? And that what we really want? Gary On Sep 14, 2016 8:46 AM, "Stian Soiland-Reyes" wrote: > This is a [VOTE] for releasing Apache Commons BeanUtils 1.9.3 (from RC2) > > > SVN tag: > https://svn.apache.org/repos/asf/commons/proper/beanutils/

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Henning Schmiedehausen
+1 for releasing. Compiled and tested on MacOS X running Java 8. -h [Seems I am still a committer. Haven't been here in a while. ] On Wed, Sep 14, 2016 at 8:45 AM, Stian Soiland-Reyes wrote: > This is a [VOTE] for releasing Apache Commons BeanUtils 1.9.3 (from RC2) > > > SVN tag: > > https:

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Stian Soiland-Reyes
I think it's from the default config of picking up earlier version, e.g. so it would find 1.9.0. Sorry, I sent the wrong hashes, will resend. On 14 Sep 2016 11:34 p.m., "Gary Gregory" wrote: > Curious: what does "Semantic Versioning: 0.0.1" mean? And that what we > really want? > > Gary > > On

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Stian Soiland-Reyes
On 14 September 2016 at 16:45, Stian Soiland-Reyes wrote: > This is a [VOTE] for releasing Apache Commons BeanUtils 1.9.3 (from RC2) > Distribution files hashes (SHA1): Sorry, previous hashes were copy-pasted wrong :-( Correct hashes (as can be verified by the dist area and Maven repo): fb8878

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Stian Soiland-Reyes
On 14 September 2016 at 23:34, Gary Gregory wrote: > Curious: what does "Semantic Versioning: 0.0.1" mean? And that what we > really want? I guess you mean as in https://stain.github.io/commons-beanutils/1.9.3-rc2/japicmp.html It's showing the calculated version difference according to semantic

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Gary Gregory
>From the src zip: MD5, SHA1, ASC OK. -1 because I cannot run 'mvn clean site' not matter what version of Java I use: 6, 7, or 8. Users must be able to download the source zip or checkout this release tag, apply mods and rebuild and see that they did not cause regressions or break things. Buildi

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Gary Gregory
TODO: [WARNING] The parameter forkMode is deprecated since version 2.14. Use forkCount and reuseForks instead. On Wed, Sep 14, 2016 at 8:45 AM, Stian Soiland-Reyes wrote: > This is a [VOTE] for releasing Apache Commons BeanUtils 1.9.3 (from RC2) > > > SVN tag: > https://svn.apache.org/repos/as

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-14 Thread Gary Gregory
On the positive side, 'mvn clean package' works with Java 6, 7, 8, and 9-ea (Windows 7 64-bit). Gary On Wed, Sep 14, 2016 at 11:00 PM, Gary Gregory wrote: > TODO: [WARNING] The parameter forkMode is deprecated since version 2.14. > Use forkCount and reuseForks instead. > > On Wed, Sep 14, 2016

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Benedikt Ritter
I don't think the site build should block a release. As you like to put it: RERO. Let's fix it in 1.9.4. Benedikt Gary Gregory schrieb am Do., 15. Sep. 2016 um 07:49 Uhr: > From the src zip: MD5, SHA1, ASC OK. > > -1 because I cannot run 'mvn clean site' not matter what version of Java I > use:

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Gary Gregory
This is not a site nit. I cannot build it at all. How do you build it? Gary On Thu, Sep 15, 2016 at 12:54 AM, Benedikt Ritter wrote: > I don't think the site build should block a release. As you like to put it: > RERO. Let's fix it in 1.9.4. > > Benedikt > > Gary Gregory schrieb am Do., 15. Se

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Stian Soiland-Reyes
I wonder if japicmp needs mvn clean package site So that it will have a JAR to compare. Did that work with you? I'll have a look at the other errors. On 15 Sep 2016 6:49 a.m., "Gary Gregory" wrote: > From the src zip: MD5, SHA1, ASC OK. > > -1 because I cannot run 'mvn clean site' not matter

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Stian Soiland-Reyes
I've raised https://github.com/siom79/japicmp/issues/148 to ask if the japicmp report can be skipped if the "mvn package" phase has not been run. If someone does 'mvn site', would it not be typically from the trunk or after running 'mvn package'? For now, do you think it's enough to add the requ

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Stian Soiland-Reyes
I tested successfully with: docker run -v $(pwd):/usr/src/app -v /usr/src/app/target -w /usr/src/app -it maven:3-jdk-7 mvn verify docker run -v $(pwd):/usr/src/app -v /usr/src/app/target -w /usr/src/app -it maven:3-jdk-8 mvn verify (both of which use Apache Maven 3.3.9) BTW: maven:3-jdk-9

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Gary Gregory
On Thu, Sep 15, 2016 at 1:34 AM, Stian Soiland-Reyes wrote: > I wonder if japicmp needs > > mvn clean package site > That does not work with Java 6, an annoyance since the requirements for this component is Java 6: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.4:si

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Gary Gregory
On Thu, Sep 15, 2016 at 2:55 AM, Stian Soiland-Reyes wrote: > I've raised https://github.com/siom79/japicmp/issues/148 to ask if the > japicmp report can be skipped if the "mvn package" phase has not been > run. > > > If someone does 'mvn site', would it not be typically from the trunk > or after

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-15 Thread Henning Schmiedehausen
I would suggest to use a build toolchain (which has been around forever) for the actual compilation and maybe raise the minimum requirement for Maven to be something more modern. So you use a JDK 7+ to drive the build process but can use a JDK 6 to actually compile the jars. We used that setup in

Re: [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-16 Thread Stian Soiland-Reyes
OK, let's remove the src/site japicmp trigger and activate it manually with -Pjapicmp only during release time - then the build should work in Java 6 even if you try to build the site. As this has just received 1 vote (2 with mine) I'll cancel the RC and also add a BUILDING.txt. On 15 September

[CANCELLED] [VOTE] Release Commons BeanUtils 1.9.3 RC2

2016-09-16 Thread Stian Soiland-Reyes
The below vote is CANCELLED. Thanks to all who helped review. I'll improve the build to match better our minimum requirement of Java 6 and try again. On 14 September 2016 at 16:45, Stian Soiland-Reyes wrote: > This is a [VOTE] for releasing Apache Commons BeanUtils 1.9.3 (from RC2) > > > SVN tag