[collections] checkstyle

2020-02-18 Thread Alex Herbert
There have been a few PRs recently in collections with simple formatting errors. These should be picked up by checkstyle to prevent correction after merge. The [collections] checkstyle configuration is old. If I replace it with the Checkstyle version close to the Sun standard [1] then there

Re: [collections] checkstyle

2020-02-18 Thread Gary Gregory
eb 18, 2020 at 1:43 PM Alex Herbert wrote: > There have been a few PRs recently in collections with simple formatting > errors. These should be picked up by checkstyle to prevent correction > after merge. > > The [collections] checkstyle configuration is old. If I replace it w

Re: [collections] checkstyle

2020-02-18 Thread Alex Herbert
een a few PRs recently in collections with simple formatting >> errors. These should be picked up by checkstyle to prevent correction >> after merge. >> >> The [collections] checkstyle configuration is old. If I replace it with >> the Checkstyle version close to the Sun st

Re: [collections] checkstyle

2020-02-19 Thread Alex Herbert
On 18/02/2020 19:04, Gary Gregory wrote: - Avoid bikeshedding for what should be in these above files by picking Commons Lang's versions of these files. I've finished the PR for collections with the new checkstyle based on lang's configuration with a few additions: 1. I added a check for t