Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Gary Gregory
You can recover from an exception, errors you are not supposed to... Gary On Sat, Dec 28, 2019, 13:53 Matt Sicker wrote: > Aren’t Errors supposed to be fatal exceptions that are generally only > caught by exception handlers rather than by calling code? Think > OutOfMemoryError or

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Matt Sicker
Aren’t Errors supposed to be fatal exceptions that are generally only caught by exception handlers rather than by calling code? Think OutOfMemoryError or StackOverflowError. On Sat, Dec 28, 2019 at 11:35 Miguel Munoz wrote: > I can't look at the code right now, but I would use an >

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Miguel Munoz
I can't look at the code right now, but I would use an IllegalStateException if the problem is caused by a user error. I would use an AssertionError if the problem is caused by a defect in the implementation. -- Miguel Muñoz On Friday, December 27, 2019, 5:45:58 PM PST, Gary Gregory

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-28 Thread Claude Warren
Wherever the note is found the javadoc should include * This implementation contains a sign-extension bug in the seed initialization. * This manifests if the seed is negative. On Sat, Dec 28, 2019 at 1:45 AM Gary Gregory wrote: > On Fri, Dec 27, 2019 at 8:17 PM wrote: > > > This is

Re: [commons-codec] branch master updated: Change AssertionError to IllegalStateException

2019-12-27 Thread Gary Gregory
On Fri, Dec 27, 2019 at 8:17 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > aherbert pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-codec.git > > > The following commit(s) were added to refs/heads/master by this