On 2016-11-01, M N wrote:
>> read never indicates EOF as it stands, I think we should return -1
>> rather than 0 when position equals size. WDYT?
> Yes, indeed the contract specifies to return -1 in this case so we
> should change this.
will do.
>>> In resize() method there is also a danger to
ook, agree or disagree, thanks.
Cheers,
Maciej
From: Stefan Bodewig
Sent: Saturday, October 22, 2016 4:46:34 PM
To: dev@commons.apache.org
Subject: Re: [compress] Added in-memory support for zip and 7z
Hi Maciej
patch applied.
On 2016-10-22, M N wrote:
> Going
Hi Maciej
patch applied.
On 2016-10-22, M N wrote:
> Going back to the fix - first I've done the homework and read the contract of
> SeekableByteChannel.position(long) method.
> It influences read() and write() operation.
> Citation of the most important part:
> "Setting the position to a v
... and patch is attached to Jira COMPRESS-327
From: M N
Sent: Saturday, October 22, 2016 2:04:53 PM
To: dev@commons.apache.org
Subject: Re: [compress] Added in-memory support for zip and 7z
All,
OK, volatile won't hurt anyway.
Going back to the fix -
.
Let me know your thougths.
Cheers,
Maciej
From: Stefan Bodewig
Sent: Friday, October 21, 2016 4:19:11 AM
To: dev@commons.apache.org
Subject: Re: [compress] Added in-memory support for zip and 7z
On 2016-10-20, wrote:
> Even when a stream is not thread
On 2016-10-20, wrote:
> Even when a stream is not thread safe I try at least to make close()
> safe/atomic as aborts and finalizers or shutdown hooks are natural
> sources for concurrency – all using close().
true.
> (However I guess it is less problematic for memory resources)
In the case of
On 2016-10-20, M N wrote:
> I have created tests for SeekableInMemoryByteChannel and spot small error.
Great, thanks Maciej.
> Attached is a patch with tests and proposed fix.
The mailing list is set up to strip attachments (at least I don't see
any). Could you attach it to a JIRA issue?
Stefa
resources)
Gruss
Bernd
--
http://bernd.eckenfels.net
>From Win 10 Mobile
Von: M N
Gesendet: Donnerstag, 20. Oktober 2016 23:11
An: dev@commons.apache.org
Betreff: Re: [compress] Added in-memory support for zip and 7z
Hi Stefan,
I have created tests for SeekableInMemoryByteChannel and spot sm
Hi Stefan,
I have created tests for SeekableInMemoryByteChannel and spot small error.
Attached is a patch with tests and proposed fix.
Regarding thread safety I think would be more clear to remove volatile and
document a class as not thread safe.
I think the need for thread safe SeekableInMe
Hi all
actually it is SeekableByteChannel-support combined with a byte[] backed
implementation of SeekableByteChannel.
Over the past few days I've rewritten the zip and 7z packages to become
independent of RandomAccessFile and thus no longer require writing to or
reading from a file. The required
10 matches
Mail list logo