Re: [compress] ZipFile and Duplicate Entries

2013-05-21 Thread Stefan Bodewig
On 2013-05-20, sebb wrote: On 20 May 2013 16:48, Stefan Bodewig bode...@apache.org wrote: I've for now fixed it in trunk by ignoring all but the last entry od the same name seen while parsing the central directory. I've chosen to pick the last since this is what ZipFile used to do for

Re: [compress] ZipFile and Duplicate Entries

2013-05-21 Thread sebb
On 21 May 2013 10:17, Stefan Bodewig bode...@apache.org wrote: On 2013-05-20, sebb wrote: On 20 May 2013 16:48, Stefan Bodewig bode...@apache.org wrote: I've for now fixed it in trunk by ignoring all but the last entry od the same name seen while parsing the central directory. I've chosen

[compress] ZipFile and Duplicate Entries

2013-05-20 Thread Stefan Bodewig
Hi, over in Ant land a bug was raised that points at a problem in ZipFile (Commons Compress' zip package is a fork of Ant's code and I try to keep them in sync). When an archive contains duplicate entries - which is totally valid in ZIPs - ZipFile's getEntry can sometimes return ZipArchiveEntry

Re: [compress] ZipFile and Duplicate Entries

2013-05-20 Thread sebb
On 20 May 2013 16:48, Stefan Bodewig bode...@apache.org wrote: Hi, over in Ant land a bug was raised that points at a problem in ZipFile (Commons Compress' zip package is a fork of Ant's code and I try to keep them in sync). When an archive contains duplicate entries - which is totally