Re: [configuration] Checkstyle settings

2016-08-10 Thread Oliver Heger
Hi, Am 10.08.2016 um 16:05 schrieb Raviteja Lokineni: > Do you guys need any help in this? I can volunteer my time to help push > this release, just let me know what needs to be done. thank you for the offering. I think, after the latest fix of Dennis, the codebase is now ready to cut another

Re: [configuration] Checkstyle settings

2016-08-10 Thread Raviteja Lokineni
Do you guys need any help in this? I can volunteer my time to help push this release, just let me know what needs to be done. On Sun, Aug 7, 2016 at 10:12 AM, Dennis Kieselhorst wrote: > Am 06.08.2016 um 17:51 schrieb Emmanuel Bourg: > > Le 2/08/2016 à 21:17, Oliver Heger a

Re: [configuration] Checkstyle settings

2016-08-07 Thread Dennis Kieselhorst
Am 06.08.2016 um 17:51 schrieb Emmanuel Bourg: > Le 2/08/2016 à 21:17, Oliver Heger a écrit : > >> Well, for me style is not that important. (We cannot even agree on a >> common style for the Commons project.) Therefore, seeing the violations >> in the report is sufficient for me. > +1, the build

Re: [configuration] Checkstyle settings

2016-08-06 Thread Emmanuel Bourg
Le 2/08/2016 à 21:17, Oliver Heger a écrit : > Well, for me style is not that important. (We cannot even agree on a > common style for the Commons project.) Therefore, seeing the violations > in the report is sufficient for me. +1, the build shouldn't fail due to style issues. Emmanuel Bourg

Re: [configuration] Checkstyle settings

2016-08-02 Thread Oliver Heger
Am 02.08.2016 um 08:54 schrieb Dennis Kieselhorst: > Am 01.08.2016 um 21:31 schrieb Oliver Heger: >> Am 31.07.2016 um 22:24 schrieb Matt Sicker: >>> Fixing all the checkstyle errors first is kind of a prerequisite to >>> enabling it by default. >>> >>> On 31 July 2016 at 15:10, Charles Honton

Re: [configuration] Checkstyle settings

2016-08-02 Thread Dennis Kieselhorst
Am 01.08.2016 um 21:31 schrieb Oliver Heger: > Am 31.07.2016 um 22:24 schrieb Matt Sicker: >> Fixing all the checkstyle errors first is kind of a prerequisite to >> enabling it by default. >> >> On 31 July 2016 at 15:10, Charles Honton wrote: >> >>> Why wouldn’t we want build to

Re: [configuration] Checkstyle settings

2016-08-01 Thread Oliver Heger
Am 31.07.2016 um 22:24 schrieb Matt Sicker: > Fixing all the checkstyle errors first is kind of a prerequisite to > enabling it by default. > > On 31 July 2016 at 15:10, Charles Honton wrote: > >> Why wouldn’t we want build to fail early if incorrect style is used? In this

Re: [configuration] Checkstyle settings

2016-07-31 Thread Matt Sicker
Fixing all the checkstyle errors first is kind of a prerequisite to enabling it by default. On 31 July 2016 at 15:10, Charles Honton wrote: > Why wouldn’t we want build to fail early if incorrect style is used? > > chas > > > On Jul 31, 2016, at 11:09 AM, Oliver Heger

Re: [configuration] Checkstyle settings

2016-07-31 Thread Charles Honton
Why wouldn’t we want build to fail early if incorrect style is used? chas > On Jul 31, 2016, at 11:09 AM, Oliver Heger > wrote: > > Hi, > > in revision 1742698 the checkstyle configuration has been changed. The > log says "fixed checkstyle violations, updated to

[configuration] Checkstyle settings

2016-07-31 Thread Oliver Heger
Hi, in revision 1742698 the checkstyle configuration has been changed. The log says "fixed checkstyle violations, updated to latest version of checkstyle-maven-plugin, ensure correct checkstyle configuration is applied in all cases". I think with the new configuration checkstyle is now run on