Re: [configuration] review for PR 30

2019-07-02 Thread Emmanuel Bourg
Le 02/07/2019 à 01:59, Gary Gregory a écrit : > What would you call the method? I don't know, setPropertyDirectInternal? It's private anyway, the name isn't important. Emmanuel Bourg - To unsubscribe, e-mail:

Re: [configuration] review for PR 30

2019-07-01 Thread Gary Gregory
On Mon, Jul 1, 2019 at 6:46 PM Emmanuel Bourg wrote: > Le 01/07/2019 à 16:26, Gary Gregory a écrit : > > > May anyone that knows enough of the internals of [configuration] please > > comment on https://github.com/apache/commons-configuration/pull/30 > > I got a quick look, besides the

Re: [configuration] review for PR 30

2019-07-01 Thread Emmanuel Bourg
Le 01/07/2019 à 16:26, Gary Gregory a écrit : > May anyone that knows enough of the internals of [configuration] please > comment on https://github.com/apache/commons-configuration/pull/30 I got a quick look, besides the setArrayProperty method that doesn't seem to have the right name (there is

[configuration] review for PR 30

2019-07-01 Thread Gary Gregory
Hi All: May anyone that knows enough of the internals of [configuration] please comment on https://github.com/apache/commons-configuration/pull/30 ? Gary