Re: [crypto] package access on ivars?

For vars that need to be accessed only within the package, there is the choice of package-protected variable or p-p getter/setter. The latter is simpler, and is my preference. The problem with methods is that in theory they are easier to deal with when maintaining API compat. Protected and public

Re: [crypto] package access on ivars?

Agree to change them to private. If there are particular fields that are always needed by a subclass, then it should be exposed as a protected method. (The class is then later free to make those on demand) On 8 November 2016 at 09:43, Gary Gregory wrote: > On Tue, Nov 8, 2016 at 1:40 AM, sebb w

Re: [crypto] package access on ivars?

On Tue, Nov 8, 2016 at 1:40 AM, sebb wrote: > On 8 November 2016 at 09:30, Gary Gregory wrote: > > On Tue, Nov 8, 2016 at 1:19 AM, sebb wrote: > > > >> On 8 November 2016 at 07:34, Stian Soiland-Reyes > wrote: > >> > I don't think binary compatibility should include package level > access, > >

Re: [crypto] package access on ivars?

On 8 November 2016 at 09:30, Gary Gregory wrote: > On Tue, Nov 8, 2016 at 1:19 AM, sebb wrote: > >> On 8 November 2016 at 07:34, Stian Soiland-Reyes wrote: >> > I don't think binary compatibility should include package level access, >> as >> > long as that package is only used within a single Co

Re: [crypto] package access on ivars?

On Tue, Nov 8, 2016 at 1:19 AM, sebb wrote: > On 8 November 2016 at 07:34, Stian Soiland-Reyes wrote: > > I don't think binary compatibility should include package level access, > as > > long as that package is only used within a single Commons JAR, then we > are > > free to change those, at lea

Re: [crypto] package access on ivars?

On 8 November 2016 at 07:34, Stian Soiland-Reyes wrote: > I don't think binary compatibility should include package level access, as > long as that package is only used within a single Commons JAR, then we are > free to change those, at least in a new minor release. (I would say even > patch level

Re: [crypto] package access on ivars?

I don't think binary compatibility should include package level access, as long as that package is only used within a single Commons JAR, then we are free to change those, at least in a new minor release. (I would say even patch level unless serialisation is used). In particular, package level acc

RE: [crypto] package access on ivars?

I think so. Thank Gary, I will look into it. Regards, Dapeng -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Tuesday, November 8, 2016 9:34 AM To: Commons Developers List Subject: Re: [crypto] package access on ivars? There are a bunch of ivars that are at

Re: [crypto] package access on ivars?

ns Developers List > Subject: Re: [crypto] package access on ivars? > > On Mon, Nov 7, 2016 at 4:11 PM, sebb wrote: > > > On 6 November 2016 at 19:56, Gary Gregory > wrote: > > > Hi all, > > > > > > I see ivars left at the package access level.

RE: [crypto] package access on ivars?

[mailto:garydgreg...@gmail.com] Sent: Tuesday, November 8, 2016 8:15 AM To: Commons Developers List Subject: Re: [crypto] package access on ivars? On Mon, Nov 7, 2016 at 4:11 PM, sebb wrote: > On 6 November 2016 at 19:56, Gary Gregory wrote: > > Hi all, > > > > I see ivar

Re: [crypto] package access on ivars?

On Mon, Nov 7, 2016 at 4:11 PM, sebb wrote: > On 6 November 2016 at 19:56, Gary Gregory wrote: > > Hi all, > > > > I see ivars left at the package access level. This must be an oversight, > > right? > > > > We can only fix that in 2.0 and a new package. What a bummer! > > I'm not sure I understa

Re: [crypto] package access on ivars?

On 6 November 2016 at 19:56, Gary Gregory wrote: > Hi all, > > I see ivars left at the package access level. This must be an oversight, > right? > > We can only fix that in 2.0 and a new package. What a bummer! I'm not sure I understand. Why would making package-protected fields private affect co

RE: [crypto] package access on ivars?

ecent fixes. Thank you :) Regards, Dapeng -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Monday, November 7, 2016 3:56 AM To: Commons Developers List Subject: [crypto] package access on ivars? Hi all, I see ivars left at the package access level. This must be a

[crypto] package access on ivars?

Hi all, I see ivars left at the package access level. This must be an oversight, right? We can only fix that in 2.0 and a new package. What a bummer! Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition