Re: [csv] CSVPrinter ResultSet quoting

2014-11-11 Thread Gary Gregory
Just to wrap up this thread, this has been fixed in svn. Gary On Sat, Nov 1, 2014 at 12:52 AM, Gary Gregory garydgreg...@gmail.com wrote: Hi Damjan, I think the process should be: create a JIRA, optionally attach a patch (or commit a fix, up to you) that includes a unit test that

Re: [csv] CSVPrinter ResultSet quoting

2014-11-03 Thread Benedikt Ritter
Makes sense to me. Go for it! 2014-11-01 5:33 GMT+01:00 Damjan Jovanovic dam...@apache.org: Hi Is there some reason CSVPrinter.printRecords(final ResultSet resultSet) retrieves all fields from the ResultSet using ResultSet.getString(), which makes QuoteMode.NON_NUMERIC quote numbers?

[csv] CSVPrinter ResultSet quoting

2014-10-31 Thread Damjan Jovanovic
Hi Is there some reason CSVPrinter.printRecords(final ResultSet resultSet) retrieves all fields from the ResultSet using ResultSet.getString(), which makes QuoteMode.NON_NUMERIC quote numbers? This seems to work a lot better: Index: src/main/java/org/apache/commons/csv/CSVPrinter.java

Re: [csv] CSVPrinter ResultSet quoting

2014-10-31 Thread Gary Gregory
Hi Damjan, I think the process should be: create a JIRA, optionally attach a patch (or commit a fix, up to you) that includes a unit test that demonstrates that there is in fact a bug to fix. The test should fail without the fix of course. Thank you, Gary On Sat, Nov 1, 2014 at 12:33 AM, Damjan