Re: [io-480] Query

2016-07-21 Thread Gary Gregory
On Thu, Jul 21, 2016 at 1:20 PM, Rajiv Jain wrote: > Where is that change if you don't mind me asking? > Here you go: https://svn.apache.org/viewvc/commons/proper/io/trunk/src/main/java/org/apache/commons/io/IOUtils.java?r1=1746593=1753638_format=h Gary > > Sent from my

Re: [io-480] Query

2016-07-21 Thread Raviteja Lokineni
http://svn.apache.org/viewvc/commons/proper/io/trunk/src/main/java/org/apache/commons/io/IOUtils.java?rev=1753638=1753637=1753638=diff On Thu, Jul 21, 2016 at 4:20 PM, Rajiv Jain wrote: > Where is that change if you don't mind me asking? > > Sent from my iPhone > > > On 21

Re: [io-480] Query

2016-07-21 Thread Rajiv Jain
Where is that change if you don't mind me asking? Sent from my iPhone > On 21 Jul 2016, at 21:05, Gary Gregory wrote: > > I already updated the Javadoc with a different change and described it in > another email. > > Gary > >> On Thu, Jul 21, 2016 at 12:23 PM, Rajiv

Re: [io-480] Query

2016-07-21 Thread Gary Gregory
I already updated the Javadoc with a different change and described it in another email. Gary On Thu, Jul 21, 2016 at 12:23 PM, Rajiv Jain wrote: > Hi > > Thanks for making it clearer. So, can my first commit ( >

Re: [io-480] Query

2016-07-21 Thread Rajiv Jain
Hi Thanks for making it clearer. So, can my first commit (https://github.com/apache/commons-io/pull/14/commits/2c801149cbb6fabcef569ac301e9933b169a5fac ) be merged? I can then close this pull

Re: [io-480] Query

2016-07-21 Thread Raviteja Lokineni
@Rajiv: Gary was talking about this commit: https://github.com/apache/commons-io/pull/14/commits/be0477b5a571ec83d8b6554e898d3710f27bd153 BTW RuntimeException is an unchecked exception, no value in declaring them in

Re: [io-480] Query

2016-07-21 Thread Rajiv Jain
Hi Gary Where is this change? I cannot find it? In addition, would it be better to totally remove the closeQuietly() method signature? As we are saying that it will be Deprecated, so people should not use it. Let me know your thoughts so that I will make the relevant changes. Thanks.

Re: [io-480] Query

2016-07-20 Thread Gary Gregory
Hi Rajiv, I added a "[Deprecated]" to the class comment for the closeQuietly() list item. I did not use the patch to use "Please note, that IOExceptions are caught but any RuntimeExceptions can be thrown from the close() method." It seems to me that a RuntimeException can be thrown from the

Re: [io-480] Query

2016-07-18 Thread Rajiv Jain
Thanks Gary. I will be patient. Thanks for replying. Rajiv > On 18 Jul 2016, at 20:56, Gary Gregory wrote: > > Hello Rajiv, > > We are all volunteers working on a large project with many components with > different levels of activity. Please be patient. Hopefully

Re: [io-480] Query

2016-07-18 Thread Gary Gregory
Hello Rajiv, We are all volunteers working on a large project with many components with different levels of activity. Please be patient. Hopefully someone will take a look at your request soon. Gary On Mon, Jul 18, 2016 at 10:16 AM, Rajiv Jain wrote: > Hi > > I have been

[io-480] Query

2016-07-18 Thread Rajiv Jain
Hi I have been working on the Apache Maven project as a contributor recently. I don’t know whether it is any different for Apache Commons IO. The procedure for Apache Maven contributions are: a) Choose a Jira ticket to work on b) Fork the project 3) Make changes 4) Apply a pull request For