Re: [lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non-ascii char) simpler unicode hex logic

2013-03-08 Thread Henri Yandell
Thanks for the report Lawrence. With regards to Sebb's comment, I'm happy to put in a JIRA, but wanted to resolve the attribution comment first: Legal: I, Lawrence Angrave (email address, angr...@illinois.edu mailto:angr...@illinois.edu), am the author and copyright holder of the new code

Fwd: [lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non-ascii char) simpler unicode hex logic

2013-03-08 Thread Henri Yandell
Noting Lawrence's response. I'll get his email's contents added to JIRA :) -- Forwarded message -- From: Lawrence Angrave angr...@illinois.edu Date: Fri, Mar 8, 2013 at 2:36 PM Subject: Re: [lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non

Re: [lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non-ascii char) simpler unicode hex logic

2013-03-08 Thread Henri Yandell
8, 2013 at 2:36 PM Subject: Re: [lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non-ascii char) simpler unicode hex logic To: Henri Yandell flame...@gmail.com On 3/8/13 12:51 PM, Henri Yandell wrote: Thanks for the report Lawrence. With regards

[lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non-ascii char) simpler unicode hex logic

2013-03-06 Thread Lawrence Angrave
Hi, Some comments that are relevant to Apache3 UnicodeEscaper and Apache2's StringEscapeUtils.java Summary- * I noticed the current Apache code creates three String objects each time it writes a unicode hexadecimal value. * Apache3 can also create a char[] array per character

Re: [lang] Fix for Apache2,Apache3 StringEscapeUtils/UnicodeEscaper (3 objects created per non-ascii char) simpler unicode hex logic

2013-03-06 Thread sebb
On 5 March 2013 22:28, Lawrence Angrave angr...@illinois.edu wrote: Hi, Thanks for the feedback. Some comments that are relevant to Apache3 UnicodeEscaper and Apache2's StringEscapeUtils.java Summary- * I noticed the current Apache code creates three String objects each time it