Re: [lang] Why have a HashSetvBitSetTest?

2017-02-25 Thread Pascal Schumacher
Hi Allon, there is this issue: https://issues.apache.org/jira/browse/LANG-1110 and this pull request: https://github.com/apache/commons-lang/pull/182 which plan to convert the test to a JMH based benchmark. I think the plan was to merge the pull request soon. If that does not happen, I'm +1

[lang] Why have a HashSetvBitSetTest?

2017-02-25 Thread Allon Mureinik
Hi all, Building commons-lang locally made me notice HashSetvBitSetTest, which made me wonder why we need it as a unit test. I'm guessing it was originally used to support a design decision about which data structure to use. But having done it, we now have a relatively slow test (on my machine -