Re: [numbers] Continued Fraction + Fraction updates

Le mer. 8 avr. 2020 à 15:58, Alex Herbert a écrit : > > > On 08/04/2020 14:08, Gilles Sadowski wrote: > > Le mer. 8 avr. 2020 à 14:26, Alex Herbert a > > écrit : > >> > >> On 08/04/2020 00:36, Gilles Sadowski wrote: > >>> 2020-04-07 23:01 UTC+02:00, Alex Herbert : > > On 7 Apr 2020, at

Re: [numbers] Continued Fraction + Fraction updates

On 08/04/2020 14:08, Gilles Sadowski wrote: Le mer. 8 avr. 2020 à 14:26, Alex Herbert a écrit : On 08/04/2020 00:36, Gilles Sadowski wrote: 2020-04-07 23:01 UTC+02:00, Alex Herbert : On 7 Apr 2020, at 17:47, Gilles Sadowski wrote: Le mar. 7 avr. 2020 à 14:54, Alex Herbert

Re: [numbers] Continued Fraction + Fraction updates

Le mer. 8 avr. 2020 à 14:26, Alex Herbert a écrit : > > > On 08/04/2020 00:36, Gilles Sadowski wrote: > > 2020-04-07 23:01 UTC+02:00, Alex Herbert : > >> > >>> On 7 Apr 2020, at 17:47, Gilles Sadowski wrote: > >>> > >>> Le mar. 7 avr. 2020 à 14:54, Alex Herbert >>>

Re: [numbers] Continued Fraction + Fraction updates

On 08/04/2020 00:36, Gilles Sadowski wrote: 2020-04-07 23:01 UTC+02:00, Alex Herbert : On 7 Apr 2020, at 17:47, Gilles Sadowski wrote: Le mar. 7 avr. 2020 à 14:54, Alex Herbert mailto:alex.d.herb...@gmail.com>> a écrit : On 07/04/2020 13:43, Alex Herbert wrote: Fraction I also did a

Re: [numbers] Continued Fraction + Fraction updates

2020-04-07 23:01 UTC+02:00, Alex Herbert : > > >> On 7 Apr 2020, at 17:47, Gilles Sadowski wrote: >> >> Le mar. 7 avr. 2020 à 14:54, Alex Herbert > > a écrit : >>> >>> On 07/04/2020 13:43, Alex Herbert wrote: Fraction I also did a big

Re: [numbers] Continued Fraction + Fraction updates

> On 7 Apr 2020, at 17:47, Gilles Sadowski wrote: > > Le mar. 7 avr. 2020 à 14:54, Alex Herbert > a écrit : >> >> On 07/04/2020 13:43, Alex Herbert wrote: >>> >>> Fraction >>> >>> I also did a big arrangement of Fraction and BigFraction. > > Thanks. > >>

Re: [numbers] Continued Fraction

> >> [...] > >> 1. Maintain functional compatibility with Commons Math > >> 2. Change for notation compatibility with the original paper > >> > >> Opinions on which action? > > > > I'm torn, since a lot of the Javadoc points to Wikipedia. > > However, if some sources explicitly discuss the

Re: [numbers] Continued Fraction + Fraction updates

Le mar. 7 avr. 2020 à 14:54, Alex Herbert a écrit : > > On 07/04/2020 13:43, Alex Herbert wrote: > > > > Fraction > > > > I also did a big arrangement of Fraction and BigFraction. Thanks. > > I noticed that hashCode is using some variant of the format used in > Arrays.hashCode(...) > > I

Re: [numbers] Continued Fraction

> I think that we then change it so it matches the source paper. It makes it > a lot easier to follow the adaption from the paper (which is only about 8 > lines of pseudocode) if the variables have the same name. > +1 Thanks for catching this interesting issue.

Re: [numbers] Continued Fraction + Fraction updates

On 07/04/2020 13:43, Alex Herbert wrote: Fraction I also did a big arrangement of Fraction and BigFraction. I noticed that hashCode is using some variant of the format used in Arrays.hashCode(...) I wondered if we should standardise on returning a value as if computed using e.g.

Re: [numbers] Continued Fraction + Fraction updates

Continued Fraction I've updated ContinuedFraction to use numerator a over denominator b. This is consistent with the original source paper for the method. Fraction While looking at the fraction package it was very hard to compare Fraction and BigFraction side-by-side. This is a problem as

Re: [numbers] Continued Fraction

> On 6 Apr 2020, at 17:38, Gilles Sadowski wrote: > > Hello Alex. > > Thanks a lot for your always-detailed investigations... :-) > > Le lun. 6 avr. 2020 à 13:09, Alex Herbert > a écrit : >> >> The ContinuedFraction class required that an implementation

Re: [numbers] Continued Fraction

Hello Alex. Thanks a lot for your always-detailed investigations... :-) Le lun. 6 avr. 2020 à 13:09, Alex Herbert a écrit : > > The ContinuedFraction class required that an implementation provide a > and b coefficients of the form: > > * b1 > * a0 + -- > *

[numbers] Continued Fraction

The ContinuedFraction class required that an implementation provide a and b coefficients of the form:  *  b1  * a0 + --  *  a1 +  b2  *   -  *   a2 +    b3  *     *    a3 + ... I added this form to