Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-02 Thread Heinrich Bohne
Agreed, but it's not clear to me that it must be part of the public API. Yes, I admit that the public API doesn't really have anything to do with this, I realize that now. If my last email suggested otherwise, this was unintentional. On 7/1/19 11:52 PM, Gilles Sadowski wrote: Hello. Le lun.

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Gilles Sadowski
Hello. Le lun. 1 juil. 2019 à 20:23, Heinrich Bohne a écrit : > > > Is there a case where *not* knowing whether the fraction is reduced or > > not is detrimental? > > Hm, maybe you're right and specifying this (as well as where the sign is > stored) in the public API is not that important, as

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Heinrich Bohne
Is there a case where *not* knowing whether the fraction is reduced or not is detrimental? Hm, maybe you're right and specifying this (as well as where the sign is stored) in the public API is not that important, as long as the combination of returned numerator and denominator is valid. The

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Gilles Sadowski
Hello. Le lun. 1 juil. 2019 à 12:35, Heinrich Bohne a écrit : > > > Couldn't it entail a loss of opportunity to allow "non-reduced" fractions > > for efficiency reason? > > Yes, it would, but I can't envision a scenario where this would be > detrimental. Of course, I may be missing something.

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Heinrich Bohne
Couldn't it entail a loss of opportunity to allow "non-reduced" fractions for efficiency reason? Yes, it would, but I can't envision a scenario where this would be detrimental. Of course, I may be missing something. But I don't follow; if it's an implementation detail, it should not appear

Re: [numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-07-01 Thread Gilles Sadowski
Hi. Le lun. 1 juil. 2019 à 03:52, Heinrich Bohne a écrit : > > I've recently been wondering about the following: > > With the resolution of NUMBERS-119 > (https://issues.apache.org/jira/browse/NUMBERS-119), all constructors in > Fraction and BigFraction reduce the created fraction to lowest

[numbers-fraction] Documentation of fractions' reduction to lowest terms

2019-06-30 Thread Heinrich Bohne
I've recently been wondering about the following: With the resolution of NUMBERS-119 (https://issues.apache.org/jira/browse/NUMBERS-119), all constructors in Fraction and BigFraction reduce the created fraction to lowest terms (in the constructor Fraction(double, double, int, int), this is not