Re: [pool][dbcp] Ongoing saga of setFactory

2011-07-07 Thread Mark Thomas
On 03/07/2011 22:43, Phil Steitz wrote: > On 7/3/11 12:32 PM, Mark Thomas wrote: >> On 26/06/2011 01:05, Phil Steitz wrote: >>> On 6/25/11 4:28 PM, Mark Thomas wrote: On 17/06/2011 09:02, Mark Thomas wrote: > On 17/06/2011 00:32, Gary Gregory wrote: >> I think 2.0 is the opportunity to

Re: [pool][dbcp] Ongoing saga of setFactory

2011-07-03 Thread Phil Steitz
On 7/3/11 12:32 PM, Mark Thomas wrote: > On 26/06/2011 01:05, Phil Steitz wrote: >> On 6/25/11 4:28 PM, Mark Thomas wrote: >>> On 17/06/2011 09:02, Mark Thomas wrote: On 17/06/2011 00:32, Gary Gregory wrote: > I think 2.0 is the opportunity to do this right. Almost like we were > desig

Re: [pool][dbcp] Ongoing saga of setFactory

2011-07-03 Thread Mark Thomas
On 26/06/2011 01:05, Phil Steitz wrote: > On 6/25/11 4:28 PM, Mark Thomas wrote: >> On 17/06/2011 09:02, Mark Thomas wrote: >>> On 17/06/2011 00:32, Gary Gregory wrote: I think 2.0 is the opportunity to do this right. Almost like we were designing this from scratch. Making the f

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-25 Thread Phil Steitz
On 6/25/11 4:28 PM, Mark Thomas wrote: > On 17/06/2011 09:02, Mark Thomas wrote: >> On 17/06/2011 00:32, Gary Gregory wrote: >>> I think 2.0 is the opportunity to do this right. Almost like we were >>> designing this from scratch. >>> >>> Making the factory an invariant of the pool sounds good. >>>

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-25 Thread Mark Thomas
On 17/06/2011 09:02, Mark Thomas wrote: > On 17/06/2011 00:32, Gary Gregory wrote: >> I think 2.0 is the opportunity to do this right. Almost like we were >> designing this from scratch. >> >> Making the factory an invariant of the pool sounds good. >> >> Otoh If a setFactory method exists it shoul

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-17 Thread Mark Thomas
On 17/06/2011 00:32, Gary Gregory wrote: > I think 2.0 is the opportunity to do this right. Almost like we were > designing this from scratch. > > Making the factory an invariant of the pool sounds good. > > Otoh If a setFactory method exists it should be implemented fully. The > throw an excepti

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-16 Thread Gary Gregory
I think 2.0 is the opportunity to do this right. Almost like we were designing this from scratch. Making the factory an invariant of the pool sounds good. Otoh If a setFactory method exists it should be implemented fully. The throw an exception impl is pretty "smelly". Gary On Jun 16, 2011, at

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-16 Thread Phil Steitz
On 6/16/11 10:19 AM, Mark Thomas wrote: > On 16/06/2011 17:32, sebb wrote: >> On 16 June 2011 17:25, Phil Steitz wrote: >>> Yesterday I fixed some [dbcp] "problems" caused by the new [pool] >>> requirement that setFactory can only be called once. The quotes are >>> because most of the problems we

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-16 Thread Mark Thomas
On 16/06/2011 17:32, sebb wrote: > On 16 June 2011 17:25, Phil Steitz wrote: >> Yesterday I fixed some [dbcp] "problems" caused by the new [pool] >> requirement that setFactory can only be called once. The quotes are >> because most of the problems were redundant calls to setFactory. >> The reaso

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-16 Thread Phil Steitz
On 6/16/11 9:32 AM, sebb wrote: > On 16 June 2011 17:25, Phil Steitz wrote: >> Yesterday I fixed some [dbcp] "problems" caused by the new [pool] >> requirement that setFactory can only be called once. The quotes are >> because most of the problems were redundant calls to setFactory. >> The reason

Re: [pool][dbcp] Ongoing saga of setFactory

2011-06-16 Thread sebb
On 16 June 2011 17:25, Phil Steitz wrote: > Yesterday I fixed some [dbcp] "problems" caused by the new [pool] > requirement that setFactory can only be called once.  The quotes are > because most of the problems were redundant calls to setFactory. > The reason that we left setFactory in [pool] is

[pool][dbcp] Ongoing saga of setFactory

2011-06-16 Thread Phil Steitz
Yesterday I fixed some [dbcp] "problems" caused by the new [pool] requirement that setFactory can only be called once. The quotes are because most of the problems were redundant calls to setFactory. The reason that we left setFactory in [pool] is that [dbcp]'s connection factory constructors call