Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Liviu Tudor
Thanks, Mark, that makes sense! In that case I will apply all the patches to 1.5 too. Thanks everyone for helping with this! Liv Liviu Tudor E: liviu.tu...@gmail.com C: +1 650-2833815 (USA) M: +44 (0)7591540313 (UK, Europe) W: http://about.me/liviutudor Skype: liviutudor I'm nobody, nobo

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Mark Thomas
On 30/07/2012 22:33, Gary Gregory wrote: > On Mon, Jul 30, 2012 at 5:21 PM, Liviu Tudor wrote: > >> Mark/Gary/Seb, >> >> Just to clarify this: I haven't touched at all the 1.5 branch -- all of >> these refer strictly to the 1.6 branch (which uses JDK 1.5 according to >> the pom and also uses Juni

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Gary Gregory
On Mon, Jul 30, 2012 at 5:21 PM, Liviu Tudor wrote: > Mark/Gary/Seb, > > Just to clarify this: I haven't touched at all the 1.5 branch -- all of > these refer strictly to the 1.6 branch (which uses JDK 1.5 according to > the pom and also uses Junit 4.10). > > So in the light of these, should I: >

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Liviu Tudor
Mark/Gary/Seb, Just to clarify this: I haven't touched at all the 1.5 branch -- all of these refer strictly to the 1.6 branch (which uses JDK 1.5 according to the pom and also uses Junit 4.10). So in the light of these, should I: 1/ also apply these patches to the 1.5 branch? 2/ downgrade junit

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread sebb
On 30 July 2012 21:16, Mark Thomas wrote: > On 30/07/2012 21:07, Liviu Tudor wrote: >> * Findbugs: indeed, some of the findbugs warnings are not entirely correct >> -- and we should probably look at using the Findbugs annotations to >> manually annotate the ones which we know to actually be false

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Mark Thomas
On 30/07/2012 21:07, Liviu Tudor wrote: > * Findbugs: indeed, some of the findbugs warnings are not entirely correct > -- and we should probably look at using the Findbugs annotations to > manually annotate the ones which we know to actually be false alarms? > There were also a couple related to pe

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Liviu Tudor
Hey Mark, * I understand about JIRA -- my question was I guess more upon the lines of should I submit a patch in JIRA (after opening a ticket) and then carry out the discussion for things like Set vs List there, or is this list a better place. I understand now that the dev list is better, thank yo

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Mark Thomas
On 30/07/2012 09:36, Liviu Tudor wrote: > Thanks very much for pointing me in the right direction, Mark! > As with all development tasks, this, however, opened up new questions -- > not entirely sure if these are best discussed on this list or whether > occasionally I should open up a JIRA ticket f

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-30 Thread Liviu Tudor
Thanks very much for pointing me in the right direction, Mark! As with all development tasks, this, however, opened up new questions -- not entirely sure if these are best discussed on this list or whether occasionally I should open up a JIRA ticket for this so more than welcoming suggestions here.

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-24 Thread Mark Thomas
On 24/07/2012 08:42, Liviu Tudor wrote: > Phil & others who have been in touch with [pool], > > A follow up to this: I'm trying to log this in JIRA and submit a patch but > I've come across the following problem: > > 1/ The mechanism I am referring to had pool-1.6.0 in mind, however, I > can't fi

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-23 Thread Liviu Tudor
Phil & others who have been in touch with [pool], A follow up to this: I'm trying to log this in JIRA and submit a patch but I've come across the following problem: 1/ The mechanism I am referring to had pool-1.6.0 in mind, however, I can't find in SVN the branch for 1.6? There are release branch

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-16 Thread Liviu Tudor
Hi Phil, Sorry to get onto this so late! I've just checked out the source code in order to provide a patch at the same time as the JIRA ticket being created, however, I see [pool] now is moving to pool2 -- my initial suggestion was based on pool-1.6.0 (which is what I use in my application). Are

Re: [pool] Question / potential improvement on KeyedObjectPool

2012-07-11 Thread Phil Steitz
On 7/10/12 2:51 PM, Liviu Tudor wrote: > Hi guys, > > I have a question regarding [pool] -- which might turned out to be either a > request for change or a potential improvement patch (though it could be the > case I suppose that I've misunderstood certain things, in which case it will > just turn

[pool] Question / potential improvement on KeyedObjectPool

2012-07-10 Thread Liviu Tudor
Hi guys, I have a question regarding [pool] -- which might turned out to be either a request for change or a potential improvement patch (though it could be the case I suppose that I've misunderstood certain things, in which case it will just turn out into my wasting people's time -- hopefully not