Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-13 Thread Alex Herbert
> On 11 May 2019, at 23:25, Alex Herbert wrote: > > > >> On 11 May 2019, at 22:58, Gilles Sadowski wrote: >> >> Le sam. 11 mai 2019 à 23:32, Alex Herbert a écrit >> : >>> >>> >>> On 10 May 2019, at 15:07, Gilles Sadowski wrote: Hi. Le ven. 10 mai 2019 à

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-11 Thread Alex Herbert
> On 11 May 2019, at 22:58, Gilles Sadowski wrote: > > Le sam. 11 mai 2019 à 23:32, Alex Herbert a écrit : >> >> >> >>> On 10 May 2019, at 15:07, Gilles Sadowski wrote: >>> >>> Hi. >>> >>> Le ven. 10 mai 2019 à 15:53, Alex Herbert >> > a écrit :

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-11 Thread Gilles Sadowski
Le sam. 11 mai 2019 à 23:32, Alex Herbert a écrit : > > > > > On 10 May 2019, at 15:07, Gilles Sadowski wrote: > > > > Hi. > > > > Le ven. 10 mai 2019 à 15:53, Alex Herbert > > a écrit : > >> > >> > >> On 10/05/2019 14:27, Gilles Sadowski wrote: > >>> Hi Alex. >

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-11 Thread Alex Herbert
> On 10 May 2019, at 15:07, Gilles Sadowski wrote: > > Hi. > > Le ven. 10 mai 2019 à 15:53, Alex Herbert > a écrit : >> >> >> On 10/05/2019 14:27, Gilles Sadowski wrote: >>> Hi Alex. >>> >>> Le ven. 10 mai 2019 à 13:57, Alex Herbert a >>> écrit :

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-10 Thread Alex Herbert
On 10/05/2019 15:07, Gilles Sadowski wrote: Hi. Le ven. 10 mai 2019 à 15:53, Alex Herbert a écrit : On 10/05/2019 14:27, Gilles Sadowski wrote: Hi Alex. Le ven. 10 mai 2019 à 13:57, Alex Herbert a écrit : Can I get a review of the PR for RNG-101 please. Thanks for this work! I didn't

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-10 Thread Alex Herbert
On 10/05/2019 15:07, Gilles Sadowski wrote: Hi. Le ven. 10 mai 2019 à 15:53, Alex Herbert a écrit : On 10/05/2019 14:27, Gilles Sadowski wrote: Hi Alex. Le ven. 10 mai 2019 à 13:57, Alex Herbert a écrit : Can I get a review of the PR for RNG-101 please. Thanks for this work! I didn't

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-10 Thread Gilles Sadowski
Hi. Le ven. 10 mai 2019 à 15:53, Alex Herbert a écrit : > > > On 10/05/2019 14:27, Gilles Sadowski wrote: > > Hi Alex. > > > > Le ven. 10 mai 2019 à 13:57, Alex Herbert a > > écrit : > >> Can I get a review of the PR for RNG-101 please. > > Thanks for this work! > > > > I didn't go into the

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-10 Thread Alex Herbert
On 10/05/2019 14:27, Gilles Sadowski wrote: Hi Alex. Le ven. 10 mai 2019 à 13:57, Alex Herbert a écrit : Can I get a review of the PR for RNG-101 please. Thanks for this work! I didn't go into the details; however, I see many fields and methods like table1 ... table5 fillTable1 ...

Re: [rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-10 Thread Gilles Sadowski
Hi Alex. Le ven. 10 mai 2019 à 13:57, Alex Herbert a écrit : > > Can I get a review of the PR for RNG-101 please. Thanks for this work! I didn't go into the details; however, I see many fields and methods like table1 ... table5 fillTable1 ... fillTable5 getTable1 ... getTable5 Wouldn't

[rng] RNG-101 new MarsagliaTsangWang discrete probability sampler

2019-05-10 Thread Alex Herbert
Can I get a review of the PR for RNG-101 please. This is a new sampler based on the source code from the paper: George Marsaglia, Wai Wan Tsang, Jingbo Wang (2004) Fast Generation of Discrete Random Variables. Journal of Statistical Software. Vol. 11, Issue. 3, pp. 1-11.