On 23/05/2019 13:46, Gilles Sadowski wrote:
Hello.
Le jeu. 23 mai 2019 à 14:10, Alex Herbert a écrit :
On 23/05/2019 12:53, sebb wrote:
Are the classes supposed to be final?
Or just the existing constructor(s)?
The two package-private classes are definitely helper classes and should
be fi
Hello.
Le jeu. 23 mai 2019 à 14:10, Alex Herbert a écrit :
>
>
> On 23/05/2019 12:53, sebb wrote:
> > Are the classes supposed to be final?
> > Or just the existing constructor(s)?
>
> The two package-private classes are definitely helper classes and should
> be final.
>
> The class with the clir
On 23/05/2019 12:53, sebb wrote:
Are the classes supposed to be final?
Or just the existing constructor(s)?
The two package-private classes are definitely helper classes and should
be final.
The class with the clirr issue (it is actually an info) only has static
methods. So currently it i
Are the classes supposed to be final?
Or just the existing constructor(s)?
On Thu, 23 May 2019 at 12:51, Gilles Sadowski wrote:
>
> Hello.
>
> Le jeu. 23 mai 2019 à 13:43, Alex Herbert a écrit :
> >
> > [rng] has three classes with a private constructor that are not
> > currently marked as final
Hello.
Le jeu. 23 mai 2019 à 13:43, Alex Herbert a écrit :
>
> [rng] has three classes with a private constructor that are not
> currently marked as final. 1 is public and 2 are package private.
>
> If I mark them as final then clirr:check ignores the package private
> ones and produces this warn
[rng] has three classes with a private constructor that are not
currently marked as final. 1 is public and 2 are package private.
If I mark them as final then clirr:check ignores the package private
ones and produces this warning for the public one:
"Added final modifier to class, but class w