Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Gary Gregory
FYI, I plan on pushing a 2.0.0-M1 this week. Gary On Tue, Jul 11, 2023 at 8:48 AM Romain Manni-Bucau wrote: > > Sounds good to me, so something like v2 will target legacy apps migrating > to jakarta but there will be no v3 so prefer migrating to servlet API - or > your env API. > > Romain

Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Romain Manni-Bucau
Sounds good to me, so something like v2 will target legacy apps migrating to jakarta but there will be no v3 so prefer migrating to servlet API - or your env API. Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Dennis Kieselhorst
> Not sure I get the why, let me summarize: > > * using [fileupload] in a servlet >= 3 container is conflicting and can > easily mess up things > * servlet provides [fileupload] api > * jetty (since you mentionned it) does not use [fileupload] ( >

Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Romain Manni-Bucau
Le mar. 11 juil. 2023 à 14:13, Maxim Solodovnik a écrit : > from mobile (sorry for typos ;) > > > On Tue, Jul 11, 2023, 18:58 Romain Manni-Bucau > wrote: > > > @Maxim: exactly, this is why hosting it only in tomcat and using the > > servlet abstraction is saner since commons is not usable in

Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Maxim Solodovnik
from mobile (sorry for typos ;) On Tue, Jul 11, 2023, 18:58 Romain Manni-Bucau wrote: > @Maxim: exactly, this is why hosting it only in tomcat and using the > servlet abstraction is saner since commons is not usable in tomcat without > relocation or hacks nobdoy wants on any sides and it is

Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Romain Manni-Bucau
@Maxim: exactly, this is why hosting it only in tomcat and using the servlet abstraction is saner since commons is not usable in tomcat without relocation or hacks nobdoy wants on any sides and it is the main relevant consumer these days. Romain Manni-Bucau @rmannibucau

Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Maxim Solodovnik
Tomcat uses the code copy\pasted from commons-fileupload (due to there was not release) IMO it is better to use library instead of copy/pasting here and there . On Tue, 11 Jul 2023 at 18:03, Romain Manni-Bucau wrote: > > This is a good point but guess it is not hard - and would be great - to

Re: Re: commons-fileupload2-jakarta

2023-07-11 Thread Romain Manni-Bucau
This is a good point but guess it is not hard - and would be great - to fix it in tomcat, just needs to not use ArrayList but a lazy list which will behave like fileupload streaming API. Under the hood the API already uses the FileItemIterator , it just needs to be able to populate the list

RE: Re: commons-fileupload2-jakarta

2023-07-11 Thread Eugene Grybinnyk
We tried to get rid of commons-fileupload in favour of Servlet API for our project where we disable multipart and use streaming (not to store files on the disk). And it looks like Servlet API doesn’t provide a convenient way of streaming the attachments (like commons-fileupload does) so in the