Re: [NUMBERS] Proposal for refactoring and extension of Gamma functions.

2017-06-07 Thread Gilles
Hello. On Wed, 07 Jun 2017 12:53:42 +, Amey Jadiye wrote: Hi Gilles, Thanks for inputs, I will generate some stats with jmh let's see if we are getting benefits with my proposal. Mean time I have submitted test cases[1] for NUMBERS-38, please review. Tabs is a "no-no". ;-) I find it

Re: [NUMBERS] Proposal for refactoring and extension of Gamma functions.

2017-06-07 Thread Amey Jadiye
Hi Gilles, Thanks for inputs, I will generate some stats with jmh let's see if we are getting benefits with my proposal. Mean time I have submitted test cases[1] for NUMBERS-38, please review. [1] https://github.com/apache/commons-numbers/pull/5 Regards, Amey On Wed, Jun 7, 2017, 4:44 AM

Re: [NUMBERS] Proposal for refactoring and extension of Gamma functions.

2017-06-06 Thread Gilles
Hi Amey. On Wed, 7 Jun 2017 01:15:01 +0530, Amey Jadiye wrote: Hi, Gamma class is written keeping in mind that it should handle fair situation (if n < 20) it computes with normal gamma function else it uses LanczosApproximation for higher numbers, for now I think we should keep it behaviour

Re: [NUMBERS] Proposal for refactoring and extension of Gamma functions.

2017-06-06 Thread Amey Jadiye
Hi, Gamma class is written keeping in mind that it should handle fair situation (if n < 20) it computes with normal gamma function else it uses LanczosApproximation for higher numbers, for now I think we should keep it behaviour as it is and do just code segrigation, by segregation of there

Re: [NUMBERS] Proposal for refactoring and extension of Gamma functions.

2017-06-05 Thread Gilles
On Tue, 6 Jun 2017 01:14:38 +0530, Amey Jadiye wrote: Hi All, Coming from discussion happened here https://issues.apache.org/jira/browse/NUMBERS-38 As Gamma is nothing but advanced factorial function gamma(n)=(n-1)! with advantages like we can have factorial of whole numbers as well as