Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread Alex Herbert
> >> > The pom would have to be >> > updated to bind the other plugins from the default goal to this phase >> with >> > executions. >> >> Is there something to be changed so [Math] is aligned with [RNG]? >> > > [RNG] also does not have executions specified for spotbugs or pmd. > apache-rat and chec

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread Alex Herbert
On Wed, 14 Jul 2021 at 11:49, Gilles Sadowski wrote: > Le mer. 14 juil. 2021 à 12:29, Alex Herbert a > écrit : > > > > The default goal specifies extra targets. Currently it is: > > > > clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check > > javadoc:javadoc > > > > We could c

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread Gilles Sadowski
Le mer. 14 juil. 2021 à 12:29, Alex Herbert a écrit : > > The default goal specifies extra targets. Currently it is: > > clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check > javadoc:javadoc > > We could change the pom to bind these targets to a lifecycle phase [1] such > as 'v

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread Alex Herbert
The default goal specifies extra targets. Currently it is: clean verify apache-rat:check checkstyle:check pmd:check spotbugs:check javadoc:javadoc We could change the pom to bind these targets to a lifecycle phase [1] such as 'verify'. Looking at the pom for CM the checkstyle plugin is configure

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread Gilles Sadowski
Le mer. 14 juil. 2021 à 12:10, sebb a écrit : > > On Wed, 14 Jul 2021 at 10:29, Gilles Sadowski wrote: > > > > Le mer. 14 juil. 2021 à 11:16, sebb a écrit : > > > > > > On Wed, 14 Jul 2021 at 10:03, Gilles Sadowski > > > wrote: > > > > > > > > Hi. > > > > > > > > Is it correct that > > > > $

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread sebb
On Wed, 14 Jul 2021 at 10:29, Gilles Sadowski wrote: > > Le mer. 14 juil. 2021 à 11:16, sebb a écrit : > > > > On Wed, 14 Jul 2021 at 10:03, Gilles Sadowski wrote: > > > > > > Hi. > > > > > > Is it correct that > > > $ mvn site site:stage > > > and > > > $ mvn > > > behave differently (i.e.

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread Gilles Sadowski
Le mer. 14 juil. 2021 à 11:16, sebb a écrit : > > On Wed, 14 Jul 2021 at 10:03, Gilles Sadowski wrote: > > > > Hi. > > > > Is it correct that > > $ mvn site site:stage > > and > > $ mvn > > behave differently (i.e. that the latter would not run "CheckStyle" or > > that it generates warnings i

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread sebb
On Wed, 14 Jul 2021 at 10:03, Gilles Sadowski wrote: > > Hi. > > Is it correct that > $ mvn site site:stage > and > $ mvn > behave differently (i.e. that the latter would not run "CheckStyle" or > that it generates warnings instead of errors)? Depends on what the POM defines as the default ta

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-14 Thread Gilles Sadowski
Hi. Is it correct that $ mvn site site:stage and $ mvn behave differently (i.e. that the latter would not run "CheckStyle" or that it generates warnings instead of errors)? In CM, we were used to detect all issues by running the former. Is it expected that it's not the case anymore? Thanks,

Re: [commons-math] branch master updated: Code simplifications (suggested by "sonarcloud").

2021-07-13 Thread Alex Herbert
On Tue, 13 Jul 2021 at 23:41, wrote: > This is an automated email from the ASF dual-hosted git repository. > > erans pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/commons-math.git > > > The following commit(s) were added to refs/heads/master by this push: >