Re: Adding module-info.java to Commons Math4

2025-08-18 Thread Gili Tzabari
I don't remember if I replied to this or not, but anyway the BND author seems to be aware of this issue and his reply was not too promising: https://github.com/bndtools/bnd/issues/5687 Personally, I think you're asking for trouble if you add module-info.class into a different directory than it

Re: Adding module-info.java to Commons Math4

2025-08-12 Thread Piotr P. Karwasz
Hi Gili, On 13.08.2025 07:43, Gili Tzabari wrote: >> Since JDK 8 is not modular, it simply treats >> `module-info.class` as a regular resource. > > I was going to ask, why risk a future problem? Couldn't you just > configure BND to place this file under META-INF/versions/9/? That’s a good questi

Re: Adding module-info.java to Commons Math4

2025-08-12 Thread Gili Tzabari
Hi Piotr, Since JDK 8 is not modular, it simply treats `module-info.class` as a regular resource. I was going to ask, why risk a future problem? Couldn't you just configure BND to place this file under META-INF/versions/9/? But then I look under https://repository.apache.org/content/groups

Re: Adding module-info.java to Commons Math4

2025-08-12 Thread Piotr P. Karwasz
Hi Gili, On 13.08.2025 01:02, Gili Tzabari wrote: > I noticed that you've been improving the modularity of the Commons Math4 > library. Can you please add module-info.java to each Maven artifact? All recent versions of Apache Commons libraries already include a JPMS descriptor, generated via the

Re: Adding module-info.java to Commons Math4

2025-08-12 Thread Gilles Sadowski
Le mer. 13 août 2025 à 01:02, Gili Tzabari a écrit : > > Hi, > > I noticed that you've been improving the modularity of the Commons Math4 > library. Can you please add module-info.java to each Maven artifact? > > If you want to maintain Java8 support, For the time being, yes (unfortunately). > y