Re: [MATH][GENETICS] Review of PR #197

Hello. Le mar. 9 nov. 2021 à 13:05, Avijit Basak a écrit : > > Hi All > > >Depending on released code (e.g. version 3.6.1 of Commons Math) > >is fine too for the "main" codes of the "examples" module. > >Setting up all the "policies" (mutation, crossover, ...) must be done > >anyways, by the

Re: [MATH][GENETICS] Review of PR #197

Hi All >Depending on released code (e.g. version 3.6.1 of Commons Math) >is fine too for the "main" codes of the "examples" module. >Setting up all the "policies" (mutation, crossover, ...) must be done >anyways, by the user; the above factories just add an argument to >be passed at

Re: [MATH][GENETICS] Review of PR #197

Hello. Side-note: Please try to not remove quotes from previous emails, as it leads to a confusing sequence (e.g. things I wrote previously now appear below as quotes from your last message). Le dim. 7 nov. 2021 à 10:34, Avijit Basak a écrit : > > Hi All > > Please find my comments

Re: [MATH][GENETICS] Review of PR #197

Hi All Please find my comments below: The convention for the log summary (first line of the log message) is to put the issue number in front; thus, instead of ---CUT--- Developed the new genetic algorithm module following the JIRA MATH-1563. ---CUT--- it should be something like

Re: [MATH][GENETICS] Review of PR #197

Hello. Le lun. 1 nov. 2021 à 08:56, Avijit Basak a écrit : > > Hi All > > Please find my comments below: > > > > > Hi All > > > > I have fixed most of the review comments. The changes have been > > committed to PR#199. > > > > (A) > > Please "rebase" on "master". > > Please

Re: [MATH][GENETICS] Review of PR #197

Hi All Please find my comments below: > > Hi All > > I have fixed most of the review comments. The changes have been > committed to PR#199. > > (A) > Please "rebase" on "master". > Please "squash" intermediate commits: For a new feature, a single commit > should exist (that

Re: [MATH][GENETICS] Review of PR #197

Le ven. 29 oct. 2021 à 17:00, Avijit Basak a écrit : > > Hi All > > I have fixed most of the review comments. The changes have been > committed to PR#199. > > (A) > Please "rebase" on "master". > Please "squash" intermediate commits: For a new feature, a single commit > should exist (that

Re: [MATH][GENETICS] Review of PR #197

Hi All I have fixed most of the review comments. The changes have been committed to PR#199. (A) Please "rebase" on "master". Please "squash" intermediate commits: For a new feature, a single commit should exist (that corresponds to the JIRA report describing it). --Will be done once all

Re: [MATH][GENETICS] Review of PR #197

Le mer. 20 oct. 2021 à 08:47, Avijit Basak a écrit : > > Hi > > Thanks for the review comments. I have started making the changes. > However, I have some queries regarding some of comments as noted below: Some (partial) answers below. > > (B) > I'm confused by your defining "legacy"

Re: [MATH][GENETICS] Review of PR #197

On Wed, 20 Oct 2021 at 07:47, Avijit Basak wrote: > (B) > I'm confused by your defining "legacy" packages in new modules... > --This is kept for comparison purposes between the legacy and the new > implementation of GA. You should be able to compare to the old implementation by including

Re: [MATH][GENETICS] Review of PR #197

Hi Thanks for the review comments. I have started making the changes. However, I have some queries regarding some of comments as noted below: (B) I'm confused by your defining "legacy" packages in new modules... --This is kept for comparison purposes between the legacy and the new

Re: [MATH][GENETICS] Review of PR #197

Hello. Sorry for the delay in reviewing. Le lun. 18 oct. 2021 à 09:35, Avijit Basak a écrit : > > Hi All > > I have created PR#197 as mentioned earlier. Kindly let me know if > there is any concern or comments. > I have created another *PR#199* consisting of the changes with >

Re: [MATH][GENETICS] Review of PR #197

gt; be appreciated. > > Thanks & Regards > --Avijit Basak > > On Mon, 27 Sept 2021 at 18:21, Avijit Basak wrote: > > > Hi All > > > > I have created the *PR #197* consisting of changes for JIRA > > MATH-1563, Task MATH-1618. This is the primary

Re: [MATH][GENETICS] Review of PR #197

I have created the *PR #197* consisting of changes for JIRA > MATH-1563, Task MATH-1618. This is the primary work to standardize the > design of GA module. The build has passed. I would like to request a review > of the PR. Once the primary design is standardized I can check in

[MATH][GENETICS] Review of PR #197

Hi All I have created the *PR #197* consisting of changes for JIRA MATH-1563, Task MATH-1618. This is the primary work to standardize the design of GA module. The build has passed. I would like to request a review of the PR. Once the primary design is standardized I can check in further

Re: [configuration] review for PR 30

Le 02/07/2019 à 01:59, Gary Gregory a écrit : > What would you call the method? I don't know, setPropertyDirectInternal? It's private anyway, the name isn't important. Emmanuel Bourg - To unsubscribe, e-mail:

Re: [configuration] review for PR 30

On Mon, Jul 1, 2019 at 6:46 PM Emmanuel Bourg wrote: > Le 01/07/2019 à 16:26, Gary Gregory a écrit : > > > May anyone that knows enough of the internals of [configuration] please > > comment on https://github.com/apache/commons-configuration/pull/30 > > I got a quick look, besides the

Re: [configuration] review for PR 30

Le 01/07/2019 à 16:26, Gary Gregory a écrit : > May anyone that knows enough of the internals of [configuration] please > comment on https://github.com/apache/commons-configuration/pull/30 I got a quick look, besides the setArrayProperty method that doesn't seem to have the right name (there is

[configuration] review for PR 30

Hi All: May anyone that knows enough of the internals of [configuration] please comment on https://github.com/apache/commons-configuration/pull/30 ? Gary

Re: [VFS] Review for PR-30

https://travis-ci.org/apache/commons-vfs/jobs/342781180 On May 15, 2018 at 13:44:25, Gary Gregory (garydgreg...@gmail.com) wrote: Hopefully I can take a look this week. Do all tests pass? Like 'mvn clean test'. Gary On Mon, May 14, 2018 at 7:44 AM, Otto Fowler

Re: [VFS] Review for PR-30

Hopefully I can take a look this week. Do all tests pass? Like 'mvn clean test'. Gary On Mon, May 14, 2018 at 7:44 AM, Otto Fowler wrote: > https://github.com/apache/commons-vfs/pull/30 > > Any chance getting some eyes on this? >

[VFS] Review for PR-30

https://github.com/apache/commons-vfs/pull/30 Any chance getting some eyes on this?

Re: Review for PR

On 25 August 2016 at 17:04, Raviteja Lokineni wrote: > The pull request is closed. If you like people to review and merge it: > >1. It should be open >2. There should be an associated JIRA issue Good advice. Also note that most developers work on ASF

Re: Review for PR

The pull request is closed. If you like people to review and merge it: 1. It should be open 2. There should be an associated JIRA issue Thanks, Raviteja On Wed, Aug 24, 2016 at 7:37 AM, Utsav Oza wrote: > While surfing through the code base I encountered few

Review for PR

While surfing through the code base I encountered few spelling errors in the comments provided alongside the code. Please review this pull request and let me know if I am attempting anything in a wrong way or not. https://github.com/apache/commons-net/pull/4 Regards Utsav