Re: svn commit: r1086057 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java test/java/org/apache/commons/math/stat/correlation/PearsonsCor

2011-03-27 Thread Phil Steitz
I would prefer not to make that method static, since that means it cannot be overridden and it is used internally in this class as well as Spearman's. If we want to provide a convenience method with static signature, we should add it to StatUtils or create a CorrelationUtils class to bundle static

Re: svn commit: r1086057 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java test/java/org/apache/commons/math/stat/correlation/PearsonsCor

2011-03-29 Thread Gilles Sadowski
On Sun, Mar 27, 2011 at 05:25:59PM -0700, Phil Steitz wrote: > I would prefer not to make that method static, since that means it > cannot be overridden and it is used internally in this class as well > as Spearman's. If we want to provide a convenience method with > static signature, we should ad

Re: svn commit: r1086057 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java test/java/org/apache/commons/math/stat/correlation/PearsonsCor

2011-03-29 Thread Phil Steitz
On 3/29/11 4:43 AM, Gilles Sadowski wrote: > On Sun, Mar 27, 2011 at 05:25:59PM -0700, Phil Steitz wrote: >> I would prefer not to make that method static, since that means it >> cannot be overridden and it is used internally in this class as well >> as Spearman's. If we want to provide a convenie

Re: svn commit: r1086057 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java test/java/org/apache/commons/math/stat/correlation/PearsonsCor

2011-03-29 Thread Gilles Sadowski
> >>> Modified: > >>> commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java > >>> URL: > >>> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java?rev=1086057&r1=10

Re: svn commit: r1086057 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java test/java/org/apache/commons/math/stat/correlation/PearsonsCor

2011-03-29 Thread sebb
On 29 March 2011 16:01, Gilles Sadowski wrote: >> >>> Modified: >> >>> commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java >> >>> URL: >> >>> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/co

Re: svn commit: r1086057 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java test/java/org/apache/commons/math/stat/correlation/PearsonsCor

2011-03-29 Thread Phil Steitz
On 3/29/11 8:01 AM, Gilles Sadowski wrote: > Modified: > commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java > URL: > http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/correlation

Re: svn commit: r1086057 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java test/java/org/apache/commons/math/stat/correlation/PearsonsCor

2011-03-29 Thread Luc Maisonobe
Le 29/03/2011 17:16, sebb a écrit : > On 29 March 2011 16:01, Gilles Sadowski wrote: >> Modified: >> commons/proper/math/trunk/src/main/java/org/apache/commons/math/stat/correlation/PearsonsCorrelation.java >> URL: >> http://svn.apache.org/viewvc/commons/proper/math/trunk/src/mai