Re: svn commit: r1292572 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java

2012-02-23 Thread Gilles Sadowski
On Thu, Feb 23, 2012 at 08:12:48AM +0100, Dennis Hendriks wrote: > Hi all, > > Now that I look at this code again, should we not attempt to avoid > divide by zero in case a == b, in this method, and perhaps other > methods of this class? > > Also, looking that the Wikipedia article, at > http://e

Re: svn commit: r1292572 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java

2012-02-23 Thread Dennis Hendriks
Sébastien Brisard wrote: Hi Dennis, Hi all, Now that I look at this code again, should we not attempt to avoid divide by zero in case a == b, in this method, and perhaps other methods of this class? I think the constructor takes care of this special case. >(...) Yes, you're right. Dennis

Re: svn commit: r1292572 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java

2012-02-23 Thread Sébastien Brisard
Hi Dennis, > Hi all, > > Now that I look at this code again, should we not attempt to avoid divide by > zero in case a == b, in this method, and perhaps other methods of this > class? > I think the constructor takes care of this special case. > > Also, looking that the Wikipedia article, at > http

Re: svn commit: r1292572 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java

2012-02-22 Thread Dennis Hendriks
Hi all, Now that I look at this code again, should we not attempt to avoid divide by zero in case a == b, in this method, and perhaps other methods of this class? Also, looking that the Wikipedia article, at http://en.wikipedia.org/wiki/Triangular_distribution (which is referenced in the ja