Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-13 Thread Simone Tripodi
> > Indeed. > > > Although this document specifies the requirements for the generation of > HTTP/1.1 messages, not all applications will be correct in their > implementation. We therefore recommend that operational applications be > tolerant of deviations whenever those deviations can be interpret

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-13 Thread Mark Thomas
On 13/03/2013 09:12, Jörg Schaible wrote: > Hi Simo, > > Simone Tripodi wrote: > >> Hi Felix! >> >>> >>> See RFC-2616 5.1.1 Method. >>> >> >> the paragraph is indeed clear about that: >> >>The Method token indicates the method to be performed on the >>resource identified by the Request-U

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-13 Thread Simone Tripodi
Hallo Jörg, > Follow the RFC. will do, I am updating FILEUPLOAD-229 then will provide the fix. Alles Gute! -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Mar 13, 2013 at 10:12 AM, Jörg Schaib

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-13 Thread Jörg Schaible
Hi Simo, Simone Tripodi wrote: > Hi Felix! > >> >> See RFC-2616 5.1.1 Method. >> > > the paragraph is indeed clear about that: > >The Method token indicates the method to be performed on the >resource identified by the Request-URI. The method is case-sensitive. > >Method

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-13 Thread Simone Tripodi
Hi Felix! > > See RFC-2616 5.1.1 Method. > the paragraph is indeed clear about that: The Method token indicates the method to be performed on the resource identified by the Request-URI. The method is case-sensitive. Method = "OPTIONS"; Section 9.2

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-13 Thread Felix Meschberger
Actually: The method is in fact case-sensitive and must be POST in uppercase. See RFC-2616 5.1.1 Method. So IMHO there is no need for equalsIgnoreCase or toLowerCase at all and "POST".equals(...) should just do it. Regards Felix Am 13.03.2013 um 08:51 schrieb Simone Tripodi: >> It would be sa

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-13 Thread Simone Tripodi
> It would be safer to use equalsIgnoreCase(), for two reasons: > - POST_METHOD case is then irrelevant (methods are usually shown as uppercase) > - toLowerCase() is Locale-dependent. +1 and it would be even faster in therms of complexity - I already voted to the issue you filled, are you going to

Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java

2013-03-12 Thread sebb
On 12 March 2013 09:05, wrote: > Author: simonetripodi > Date: Tue Mar 12 09:05:06 2013 > New Revision: 1455456 > > URL: http://svn.apache.org/r1455456 > Log: > trivial: extracted POST string constant > > Modified: > > commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileuplo