subject:"svn commit\: r1456852 \- \/commons\/proper\/fileupload\/trunk\/src\/main\/java\/org\/apache\/commons\/fileupload\/util\/mime\/QuotedPrintableDecoder.java"

Re: svn commit: r1456852 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-18 Thread sebb

On 17 March 2013 11:02, sebb seb...@gmail.com wrote: See other comments on magic number fixes. I don't think these changes achieve anything apart from keeping Checkstyle happy. IMO the number is still magic (unexplained) when it is turned into a constant, and it seems stilly to have a

Re: svn commit: r1456852 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/util/mime/QuotedPrintableDecoder.java

2013-03-17 Thread sebb

See other comments on magic number fixes. I don't think these changes achieve anything apart from keeping Checkstyle happy. IMO the number is still magic (unexplained) when it is turned into a constant, and it seems stilly to have a constant that is only used once. On 15 March 2013 10:02,