Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread sebb
Turns out the problem was caused by a NUL in the string in decodeWithInnerPad() - diff then treats the file as binary. Replaced with \0 for now. On 19 March 2013 20:02, sebb wrote: > On 19 March 2013 19:16, sebb wrote: >> On 19 March 2013 18:52, Simone Tripodi wrote: >>> 3 commits? :O >> >> T

Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread sebb
On 19 March 2013 19:16, sebb wrote: > On 19 March 2013 18:52, Simone Tripodi wrote: >> 3 commits? :O > > This one, and: > > r1458269 > http://mail-archives.apache.org/mod_mbox/commons-commits/201303.mbox/%3C20130319132232.8ABD023888EA%40eris.apache.org%3E > > and > > r1458277 > http://mail-archiv

Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread sebb
On 19 March 2013 18:52, Simone Tripodi wrote: > 3 commits? :O This one, and: r1458269 http://mail-archives.apache.org/mod_mbox/commons-commits/201303.mbox/%3C20130319132232.8ABD023888EA%40eris.apache.org%3E and r1458277 http://mail-archives.apache.org/mod_mbox/commons-commits/201303.mbox/%3C20

Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread Simone Tripodi
3 commits? :O sorry, I have no clue, svn history shows that only once... -Simo stripodi$ svn log r1458278 | simonetripodi | 2013-03-19 14:44:37 +0100 (Tue, 19 Mar 2013) | 1 line [FILEUPLOAD-232] initial checkin of QuotedP

Re: svn commit: r1458266 - /commons/proper/fileupload/trunk/src/test/java/org/apache/commons/fileupload/util/mime/Base64DecoderTestCase.java

2013-03-19 Thread sebb
On 19 March 2013 13:08, wrote: > Author: simonetripodi > Date: Tue Mar 19 13:08:50 2013 > New Revision: 1458266 > > URL: http://svn.apache.org/r1458266 > Log: > added a test where the encoded input string has the padding char in the > middle; contrary to commons-codec, it doesn't halt and contin