Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-29 Thread Stefan Bodewig
On 2013-05-29, sebb wrote: > On 29 May 2013 05:13, Stefan Bodewig wrote: >> On 2013-05-28, Gary Gregory wrote: >>> On Tue, May 28, 2013 at 2:08 PM, sebb wrote: On 25 May 2013 18:47, wrote: >> import java.util.Deque; That requires Java 1.6; Compress currently targets 1.5 >>>

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-29 Thread sebb
On 29 May 2013 05:13, Stefan Bodewig wrote: > On 2013-05-28, Gary Gregory wrote: > >> On Tue, May 28, 2013 at 2:08 PM, sebb wrote: > >>> On 25 May 2013 18:47, wrote: > + import java.util.Deque; > >>> That requires Java 1.6; Compress currently targets 1.5 > >> Well, let's change the requirem

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread Stefan Bodewig
On 2013-05-28, Gary Gregory wrote: > On Tue, May 28, 2013 at 2:08 PM, sebb wrote: >> On 25 May 2013 18:47, wrote: >>>+ import java.util.Deque; >> That requires Java 1.6; Compress currently targets 1.5 > Well, let's change the requirement to Java 6 for Compress 1.6. Not necessary in this ca

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread sebb
Turns out that a List is sufficient; no need for a Deque. Fixed in http://svn.apache.org/r1487167 On 28 May 2013 19:08, sebb wrote: > On 25 May 2013 18:47, wrote: >> Author: bodewig >> Date: Sat May 25 17:47:00 2013 >> New Revision: 1486348 >> >> URL: http://svn.apache.org/r1486348 >> Log: >>

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread Oliver Kopp
Hi, Gary wrote: > I'd rather see developers getting and staying involved than clamping new > versions down with old EOL'd JREs. According to http://www.oracle.com/technetwork/java/eol-135779.html, Java 6 already had its EOL on Feb 2013. Java 7 will have its EOL on March 2015 :). Debian stable su

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread sebb
On 28 May 2013 19:28, Gary Gregory wrote: > On Tue, May 28, 2013 at 2:22 PM, sebb wrote: > >> On 28 May 2013 19:15, Gary Gregory wrote: >> > On Tue, May 28, 2013 at 2:08 PM, sebb wrote: >> > >> >> On 25 May 2013 18:47, wrote: >> >> > Author: bodewig >> >> > Date: Sat May 25 17:47:00 2013 >> >

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread Gary Gregory
On Tue, May 28, 2013 at 2:22 PM, sebb wrote: > On 28 May 2013 19:15, Gary Gregory wrote: > > On Tue, May 28, 2013 at 2:08 PM, sebb wrote: > > > >> On 25 May 2013 18:47, wrote: > >> > Author: bodewig > >> > Date: Sat May 25 17:47:00 2013 > >> > New Revision: 1486348 > >> > > >> > URL: http://s

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread sebb
On 28 May 2013 19:15, Gary Gregory wrote: > On Tue, May 28, 2013 at 2:08 PM, sebb wrote: > >> On 25 May 2013 18:47, wrote: >> > Author: bodewig >> > Date: Sat May 25 17:47:00 2013 >> > New Revision: 1486348 >> > >> > URL: http://svn.apache.org/r1486348 >> > Log: >> > provide access to all entri

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread Gary Gregory
On Tue, May 28, 2013 at 2:08 PM, sebb wrote: > On 25 May 2013 18:47, wrote: > > Author: bodewig > > Date: Sat May 25 17:47:00 2013 > > New Revision: 1486348 > > > > URL: http://svn.apache.org/r1486348 > > Log: > > provide access to all entries of a given name in ZipFile, COMPRESS-227 > > -1, se

Re: svn commit: r1486348 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ZipFile.java test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

2013-05-28 Thread sebb
On 25 May 2013 18:47, wrote: > Author: bodewig > Date: Sat May 25 17:47:00 2013 > New Revision: 1486348 > > URL: http://svn.apache.org/r1486348 > Log: > provide access to all entries of a given name in ZipFile, COMPRESS-227 -1, see below > Modified: > > commons/proper/compress/trunk/src/ma