Re: svn commit: r1729274 [3/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/

2016-02-08 Thread Emmanuel Bourg
Le 8/02/2016 22:56, ggreg...@apache.org a écrit : > Modified: > commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java > URL: > http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java

Re: svn commit: r1729274 [3/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/

2016-02-08 Thread Gary Gregory
On Feb 8, 2016 2:08 PM, "Emmanuel Bourg" wrote: > > Le 8/02/2016 22:56, ggreg...@apache.org a écrit : > > Modified: commons/proper/dbcp/trunk/src/main/java/org/apache/commons/dbcp2/DelegatingPreparedStatement.java > > URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/main/java/org/ap

Re: svn commit: r1729274 [3/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/

2016-02-08 Thread Emmanuel Bourg
Le 8/02/2016 23:51, Gary Gregory a écrit : > It's simpler to be consistent when using final IMO. The intent is the same: > https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ "The road to hell is paved with good intentions" comes to mind here. I understand the intent but I don't

Re: svn commit: r1729274 [3/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/

2016-02-08 Thread Gary Gregory
On Feb 8, 2016 3:17 PM, "Emmanuel Bourg" wrote: > > Le 8/02/2016 23:51, Gary Gregory a écrit : > > > It's simpler to be consistent when using final IMO. The intent is the same: > > https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ > > "The road to hell is paved with good intenti

Re: svn commit: r1729274 [3/7] - in /commons/proper/dbcp/trunk/src: main/java/org/apache/commons/dbcp2/ main/java/org/apache/commons/dbcp2/cpdsadapter/ main/java/org/apache/commons/dbcp2/datasources/

2016-02-08 Thread Mark Thomas
On 8 February 2016 23:17:35 GMT+00:00, Emmanuel Bourg wrote: >Le 8/02/2016 23:51, Gary Gregory a écrit : > >> It's simpler to be consistent when using final IMO. The intent is the >same: >> https://garygregory.wordpress.com/2013/01/26/the-final-kiss-in-java/ > >"The road to hell is paved with good